dump MySQL to AWS S3

[simsong]

This dumps all of the MySQL databases to AWS S3.
It will be called from a cron job on a daily basis in the production environment.

[sbarber2]

I think given that the test runs are failing that at least one change to the repo is needed!

[sbarber2]

Well, I mean, the test runs seem to be failing because this condition is not satisfied by the tests.

[sbarber2]

Ah, yes it would,

…

On Thu, Apr 10, 2025 at 10:17 PM Simson L. Garfinkel < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In deploy/app/dbmaint.py <#688 (comment)>: > + """Backup to an sqlfile""" + if os.path.exists(fname): + raise FileExistsError(f"{fname} exists") + dbreader = dbfile.DBMySQLAuth.FromConfig(config['dbreader']) + cmd = ['mysqldump','-h' + dbreader.host,'-u' + dbreader.user, '-p' + dbreader.password, '--single-transaction', '--no-tablespaces'] + if all_databases: + cmd.append('--all-databases') + else: + cmd.append(dbreader.database) + if fname.startswith('s3://'): + print("Dumping to ",fname) + with subprocess.Popen(['aws','s3','cp','-',fname], stdin=subprocess.PIPE) as p_s3: + subprocess.run(cmd, stdout=p_s3.stdin) + print("done") + return + with open(fname,'w') as outfile: Won't the return statement in line 378 prevent that? — Reply to this email directly, view it on GitHub <#688 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFQOBYCVSS65SX4OZY3CJD2Y4Q4RAVCNFSM6AAAAAB2WDPA2GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONJZGAYDAOBSGY> . You are receiving this because you commented.Message ID: ***@***.***>

[simsong]

If you think that adding and else would be more clear, we can do that.

[codecov]

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 70.11%. Comparing base (29b3693) to head (efc8b76).

Files with missing lines	Patch %	Lines
deploy/app/dbmaint.py	6.25%	15 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   70.37%   70.11%   -0.27%     
==========================================
  Files          36       36              
  Lines        3885     3901      +16     
  Branches       64       64              
==========================================
+ Hits         2734     2735       +1     
- Misses       1126     1141      +15     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sbarber2]

arts.sqlbackup probably needs to be args.sqlbackup

[sbarber2]

typo in latest comment: arts vs args; see comment