-
Notifications
You must be signed in to change notification settings - Fork 2
dump MySQL to AWS S3 #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simsong
wants to merge
4
commits into
main
Choose a base branch
from
dev-dump-to-s3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
dump MySQL to AWS S3 #688
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ | |
|
||
if __name__ == "__main__": | ||
import argparse | ||
parser = argparse.ArgumentParser(description="Database Maintenance Program. The database to act upon is specified in the ini file specified by the PLANTTRACER_CREDENTIALS environment variable, in the sections for [dbreader] and [dbwriter]", | ||
parser = argparse.ArgumentParser(description="Database Maintenance Program. The database to act upon is specified in the ini file with the --readconfig or --rootconfig", | ||
formatter_class=argparse.ArgumentDefaultsHelpFormatter) | ||
required = parser.add_argument_group('required arguments') | ||
required.add_argument( | ||
|
@@ -48,7 +48,8 @@ | |
parser.add_argument("--freshen",help="Non-destructive cleans up the movie metadata for all movies.",action='store_true') | ||
parser.add_argument("--clean",help="Destructive cleans up the movie metadata for all movies.",action='store_true') | ||
parser.add_argument("--schema", help="Specify schema file to use", default=paths.SCHEMA_FILE) | ||
parser.add_argument("--dump", help="Backup all objects as JSON files and movie files to new directory called DUMP. ") | ||
parser.add_argument("--dump", help="Dump all objects as JSON files and movie files to new directory called DUMP.") | ||
parser.add_argument("--sqlbackup", help="Backup the MySQL database to a single SQL file") | ||
parser.add_argument("--add_admin", help="Add --admin_email user as a course admin to the course specified by --course_id, --course_name, or --course_name", action='store_true') | ||
parser.add_argument("--course_id", help="integer course id", type=int) | ||
parser.add_argument("--course_key", help="integer course id") | ||
|
@@ -236,6 +237,17 @@ | |
dbmaint.freshen(True) | ||
sys.exit(0) | ||
|
||
# These need a database config | ||
if ('dbreader' not in config) and (args.dump or args.sqlbackup): | ||
print("Please use --rootconfig to specify which configuration file to use") | ||
exit(1) | ||
|
||
if args.dump: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, I mean, the test runs seem to be failing because this condition is not satisfied by the tests. |
||
dbmaint.dump(config,args.dump) | ||
sys.exit() | ||
|
||
if args.sqlbackup: | ||
dbmaint.sqlbackup(config,args.sqlbackup,all_databases=True) | ||
sys.exit() | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arts.sqlbackup probably needs to be args.sqlbackup