Replace pandas date_range API with DatetimeIndex in tests#717
Closed
arhamchopra wants to merge 1 commit into
Closed
Replace pandas date_range API with DatetimeIndex in tests#717arhamchopra wants to merge 1 commit into
arhamchopra wants to merge 1 commit into
Conversation
Signed-off-by: Arham Chopra <arham.chopra@cubistsystematic.com>
arhamchopra
requested review from
AdamGlustein,
alexddobkin,
robambalu and
svatasoiu
as code owners
robambalu
approved these changes
Jun 29, 2026
Collaborator
Author
|
Not needed pandas 3.0.4 was yanked from Pypi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
pandas.date_range(...)withpandas.DatetimeIndex([...]).as_unit("ns")in two test helpers incsp/tests/adapters/test_parquet.py(test_parquet_writerandtest_arrow_writer).Reason
pandas.date_range(..., freq="1s", tz="UTC")segfaults under pandas 3.0.4 + numpy<2.5 due to apandas._libs.tslibsoffset ABI mismatch — the frequency/offset path is compiled Cython code that crashes when built against an incompatible numpy ABI. The new approach constructs the index directly from explicitdatetimevalues, avoiding the offset code path entirely.Equivalence
The replacement is behaviorally identical to the original:
start_time + 1s … start_time + 10s(10 timestamps).datetime64[ns, UTC]. UTC is preserved becausestart_timeis tz-aware (tzinfo=pytz.utc), and.as_unit("ns")forces nanosecond resolution.Both affected tests pass.