fix: use cryptographic RNG for order salt#21
Closed
deipeypaanchal wants to merge 1 commit into
Closed
Conversation
`generate_order_salt` used `int(random.random() * current_ms_time)`,
which has three problems:
1. `random.random()` is not a cryptographic RNG.
2. Because `random.random()` is in [0, 1), the salt is always strictly
less than `current_ms_time` — not a full 64-bit uniform distribution.
3. Concurrent order creation in the same millisecond can produce
colliding salts, which the exchange rejects as duplicates.
Switch to `secrets.randbits(64)` for 64 bits of uniform, cryptographic
entropy — well within the uint256 salt field.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
scutuatua-crypto
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_order_saltwasint(random.random() * current_ms_time):random.random()is not cryptographic.current_ms_time, so the salt is not uniformly distributed.secrets.randbits(64)— 64 bits of uniform cryptographic entropy, well within theuint256salt field.Test plan
🤖 Generated with Claude Code
Note
Low Risk
Small, localized change to salt generation; low risk aside from potential downstream assumptions about salt format/range.
Overview
generate_order_saltnow usessecrets.randbits(64)instead of arandom.random() * time-based value, improving entropy, uniformity, and reducing collision risk during concurrent order creation.Reviewed by Cursor Bugbot for commit 275f951. Bugbot is set up for automated code reviews on this repo. Configure here.