Skip to content

fix: use cryptographic RNG for order salt #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deipeypaanchal wants to merge 1 commit into from
Closed

fix: use cryptographic RNG for order salt #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions py_clob_client_v2/order_utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import random
import time
import secrets


def generate_order_salt() -> str:
return str(int(random.random() * (time.time_ns() // 1_000_000)))
# 64 bits of entropy from a cryptographically strong RNG. The previous
# implementation used `random.random() * current_ms_time`, which:
# - is not cryptographically secure
# - always yields a value strictly less than `current_ms_time`
# - has a realistic collision rate under concurrent order creation
return str(secrets.randbits(64))