-
Notifications
You must be signed in to change notification settings - Fork 585
feat: exclude wrangler configuration from the code #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
3. Create a `wrangler` configuration file from the example one we have | ||
|
||
```sh | ||
cp wrangler.toml.example wrangler.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer keeping a default wrangler file instead of an example file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keeping the default file will cause a conflict when editing it by the user and later on by the owner of the code.
This is the whole idea of the PR
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
This PR adds
wrangler.toml
andwrangler.json
to.gitignore
and provides an example configuration file instead. This prevents merge conflicts that frequently occur when developers modify their local configuration files and then try to pull the latest code.Motivation
By excluding these configuration files from version control and providing example templates instead, developers can: