Skip to content

feat: exclude wrangler configuration from the code #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: exclude wrangler configuration from the code #1096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d9b792
feat: add wrangler configuration files to .gitignore and create examp…
zaherg May 14, 2025
8617165
update deployment instructions to include wrangler configuration setup
zaherg May 14, 2025
8326fdb
Merge branch 'main' into main
zaherg May 15, 2025
049a6ec
Merge branch 'main' into main
zaherg May 15, 2025
44adc6b
Merge branch 'main' into main
zaherg May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ build
# Wrangler temp directory
.wrangler

# Wrangler config file
wrangler.toml
wrangler.json

# IntelliJ Idea
.idea
plugins/**/.creds.json
Expand Down
8 changes: 7 additions & 1 deletion docs/installation-deployments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,13 @@ cd gateway
npm install
```

3. Deploy (using [Wrangler CLI](https://developers.cloudflare.com/workers/wrangler/))
3. Create a `wrangler` configuration file from the example one we have

```sh
cp wrangler.toml.example wrangler.toml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer keeping a default wrangler file instead of an example file

Copy link
Author

@zaherg zaherg May 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping the default file will cause a conflict when editing it by the user and later on by the owner of the code.

This is the whole idea of the PR

```

4. Deploy (using [Wrangler CLI](https://developers.cloudflare.com/workers/wrangler/))

```sh
npm run deploy
Expand Down
0 wrangler.toml → wrangler.toml.example
View file
Open in desktop
File renamed without changes.