feat: add more debug signals #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: app.greptile.com/review/github.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
pauldambra
commented
Feb 17, 2025
Comment on lines
+995
to
+998
| properties['$sdk_debug_replay_internal_buffer_length'] = this.sessionRecording['buffer'].data.length | ||
| properties['$sdk_debug_replay_internal_buffer_size'] = this.sessionRecording['buffer'].size | ||
| } | ||
| properties['$sdk_debug_retry_queue_size'] = this._retryQueue?.['queue']?.length |
There was a problem hiding this comment.
this should give us a view on how much data replay is currently holding
and whether the SDK retry queue is high
hopefully giving signal that e.g. network requests to send data are failing in replay
when smaller event data might be succeeding
|
Size Change: +3.48 kB (+0.11%) Total Size: 3.31 MB
ℹ️ View Unchanged
|
oliverb123
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it can be tricky to know what is happening when users report errors
let's add more debug signals
needs a follow-up to add these to core definitions