Skip to content

fix(prefect-server): add ephemeral storage requests and limits#603

Open
lostkamp wants to merge 1 commit intoPrefectHQ:mainfrom
lostkamp:add-storage
Open

fix(prefect-server): add ephemeral storage requests and limits#603
lostkamp wants to merge 1 commit intoPrefectHQ:mainfrom
lostkamp:add-storage

Conversation

@lostkamp
Copy link

@lostkamp lostkamp commented Mar 5, 2026

Summary

Hi,

sometimes it is necessary to specify these, so I thought I'd add them. I added them as comments to the values.yaml like they are already in other sections there.

Requirements

  • Contributing guide has been read
  • Title follows the conventional commits format
  • Body includes Closes <issue>, if available
  • Added/modified configuration includes a descriptive comment for documentation generation
  • Unit tests are added/updated
  • Deprecation/removal checks are added in templates/NOTES.txt
  • Relevant labels are added
  • Draft status is used until ready for review

@lostkamp lostkamp requested a review from a team as a code owner March 5, 2026 15:13
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:13 — with GitHub Actions Waiting
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:13 — with GitHub Actions Waiting
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:13 — with GitHub Actions Waiting
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:13 — with GitHub Actions Waiting
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:13 — with GitHub Actions Waiting
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:13 — with GitHub Actions Waiting
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:13 — with GitHub Actions Waiting
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:13 — with GitHub Actions Waiting
@mitchnielsen mitchnielsen changed the title fix(prefect-server) Add missing ephemeral storage requests and limits fix(prefect-server): add ephemeral storage requests and limits Mar 9, 2026
@mitchnielsen mitchnielsen added the enhancement An improvement of an existing feature label Mar 9, 2026
@mitchnielsen mitchnielsen self-requested a review March 9, 2026 21:10
Copy link
Contributor

@mitchnielsen mitchnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @lostkamp! Just two small requests.

"type": "string",
"description": "Memory request for the migration job"
},
"ephemeral-storage": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ephemeral-storage": {
"ephemeral-storage": {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get some unit tests in place for these new potential values? You can see lines 248-277 of server_test.yaml for an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants