fix(prefect-server): add ephemeral storage requests and limits#603
Open
lostkamp wants to merge 1 commit intoPrefectHQ:mainfrom
Open
fix(prefect-server): add ephemeral storage requests and limits#603lostkamp wants to merge 1 commit intoPrefectHQ:mainfrom
lostkamp wants to merge 1 commit intoPrefectHQ:mainfrom
Conversation
mitchnielsen
requested changes
Mar 9, 2026
Contributor
mitchnielsen
left a comment
There was a problem hiding this comment.
Thanks for the contribution @lostkamp! Just two small requests.
| "type": "string", | ||
| "description": "Memory request for the migration job" | ||
| }, | ||
| "ephemeral-storage": { |
Contributor
There was a problem hiding this comment.
Suggested change
| "ephemeral-storage": { | |
| "ephemeral-storage": { |
Contributor
There was a problem hiding this comment.
Could we get some unit tests in place for these new potential values? You can see lines 248-277 of server_test.yaml for an example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi,
sometimes it is necessary to specify these, so I thought I'd add them. I added them as comments to the values.yaml like they are already in other sections there.
Requirements
Closes <issue>, if availabletemplates/NOTES.txtDraftstatus is used until ready for review