Skip to content

fix(prefect-server): add ephemeral storage requests and limits #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lostkamp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(prefect-server): add ephemeral storage requests and limits #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions charts/prefect-server/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,10 @@
"memory": {
"type": "string",
"description": "Memory request for the migration job"
},
"ephemeral-storage": {
Copy link
Contributor

@mitchnielsen mitchnielsen Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ephemeral-storage": {
"ephemeral-storage": {

"type": "string",
"description": "Ephemeral storage request for the migration job"
}
}
},
Expand All @@ -136,6 +140,10 @@
"memory": {
"type": "string",
"description": "Memory limit for the migration job"
},
"ephemeral-storage": {
"type": "string",
"description": "Ephemeral storage limit for the migration job"
}
}
}
Expand Down Expand Up @@ -819,6 +827,9 @@
},
"memory": {
"type": "string"
},
"ephemeral-storage": {
"type": "string"
}
}
},
Expand All @@ -831,6 +842,9 @@
},
"memory": {
"type": "string"
},
"ephemeral-storage": {
"type": "string"
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions charts/prefect-server/values.yaml
View file
Open in desktop
Copy link
Contributor

@mitchnielsen mitchnielsen Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get some unit tests in place for these new potential values? You can see lines 248-277 of server_test.yaml for an example.

Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,11 @@ migrations:
requests:
cpu: 100m
memory: 128Mi
# ephemeral-storage:
limits:
cpu: 500m
memory: 256Mi
# ephemeral-storage:
# -- job security context configuration
securityContext:
runAsUser: 1001
Expand Down Expand Up @@ -318,10 +320,12 @@ backgroundServices:
requests:
cpu: 500m
memory: 512Mi
# ephemeral-storage:
# -- the requested limits for the background-services container
limits:
cpu: "1"
memory: 1Gi
# ephemeral-storage:

# ref: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#set-the-security-context-for-a-pod
podSecurityContext:
Expand Down
Loading