-
Notifications
You must be signed in to change notification settings - Fork 5
Add support for managing base job templates #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
48aa757
Add support for managing base job templates
tinkerborg ebed1ec
fix failing tests
tinkerborg 586845f
add support for job template patches and configmap reference
tinkerborg d1299c8
default to kubernetes pool type, cleanup
tinkerborg 571af81
add unit tests for base job templates
tinkerborg 7dead80
Merge branch 'main' into base-job-templates
tinkerborg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package v1 | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| corev1 "k8s.io/api/core/v1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| ) | ||
|
|
||
| type RawValueSource struct { | ||
| Value *runtime.RawExtension `json:"value,omitempty"` | ||
| ConfigMap *corev1.ConfigMapKeySelector `json:"configMap,omitempty"` | ||
| Patches []JsonPatch `json:"patches,omitempty"` | ||
| } | ||
|
|
||
| type JsonPatch struct { | ||
| Operation string `json:"op"` | ||
| Path string `json:"path"` | ||
|
|
||
| // +kubebuilder:pruning:PreserveUnknownFields | ||
| // +kubebuilder:validation:Schemaless | ||
| Value *runtime.RawExtension `json:"value,omitempty"` | ||
| } | ||
|
|
||
| // TODO - no admission webhook yet | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great call, we've been needing this for a while, I made an issue for it: #195 |
||
| func (spec *RawValueSource) Validate() error { | ||
| if spec.Value != nil && spec.ConfigMap != nil { | ||
| return fmt.Errorf("value and configMap are mutually exclusive") | ||
| } | ||
| return nil | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 How were we getting away without the
Idbefore? I guess the API mostly deals in work pool names rather than IDs, but this is a good addition for sure.