Add support for managing base job templates#194
Merged
chrisguidry merged 6 commits intoPrefectHQ:mainfrom Sep 16, 2025
Merged
Conversation
tinkerborg
force-pushed
the
base-job-templates
branch
from
ae9a37d to
48aa757
Compare
chrisguidry
reviewed
Sep 5, 2025
Collaborator
chrisguidry
left a comment
chrisguidry
left a comment
There was a problem hiding this comment.
Looks pretty solid from my seat, would just like to see some more unit tests if you have the bandwidth.
| type PrefectWorkPoolStatus struct { | ||
| // Id is the workPool ID from Prefect | ||
| // +optional | ||
| Id *string `json:"id,omitempty"` |
Collaborator
There was a problem hiding this comment.
👍 How were we getting away without the Id before? I guess the API mostly deals in work pool names rather than IDs, but this is a good addition for sure.
tinkerborg
force-pushed
the
base-job-templates
branch
from
bf5aa12 to
5a47694
Compare
tinkerborg
force-pushed
the
base-job-templates
branch
from
5a47694 to
81661ae
Compare
tinkerborg
force-pushed
the
base-job-templates
branch
from
81661ae to
586845f
Compare
chrisguidry
reviewed
Sep 10, 2025
| Value *runtime.RawExtension `json:"value,omitempty"` | ||
| } | ||
|
|
||
| // TODO - no admission webhook yet |
Collaborator
There was a problem hiding this comment.
Great call, we've been needing this for a while, I made an issue for it: #195
chrisguidry
reviewed
Sep 10, 2025
Collaborator
chrisguidry
left a comment
chrisguidry
left a comment
There was a problem hiding this comment.
Love the direction! Tag me when you're ready for a review 🙇
Contributor
Author
Sorry for the delay.. ready! @chrisguidry |
tinkerborg
force-pushed
the
base-job-templates
branch
from
1dadbaf to
571af81
Compare
chrisguidry
approved these changes
Sep 16, 2025
Collaborator
chrisguidry
left a comment
chrisguidry
left a comment
There was a problem hiding this comment.
Thank you for this one, @tinkerborg!
Collaborator
|
@tinkerborg and @Blarc, this is merged now and there are dev versions of the image and chart available: Image: Once we've had some chances to test this out, I'll cut a release. |
mitchnielsen
added a commit
that referenced
this pull request
Dec 17, 2025
The operator needs to read ConfigMaps from any namespace where users deploy PrefectWorkPools or PrefectServers. This was missed when PR #194 added ConfigMap watching for base job templates - the controller calls `Watches(&corev1.ConfigMap{}, ...)` which requires cluster-wide list/watch permissions to sync the informer at startup. Without these permissions, the operator fails with RBAC errors and enters CrashLoopBackOff. Closes #234 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
mitchnielsen
added a commit
that referenced
this pull request
Dec 17, 2025
## Summary The operator needs to read ConfigMaps from any namespace where users deploy PrefectWorkPools or PrefectServers. This was missed when PR #194 added ConfigMap watching for base job templates - the controller calls `Watches(&corev1.ConfigMap{}, ...)` which requires cluster-wide list/watch permissions to sync the informer at startup. Without these permissions, the operator fails with RBAC errors and enters CrashLoopBackOff. The existing unit tests didn't catch this because envtest doesn't enforce RBAC - it's a simulated API server that grants all permissions. This kind of issue only surfaces when deploying to a real cluster. To confirm this, I deployed to a local cluster: ``` $ kubectl get pods -n prefect-system NAME READY STATUS RESTARTS AGE prefect-operator-564fbfd7c9-kr5k6 1/1 Running 0 4m30s ``` Closes #234 Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements support for managing workpool base job templates.
Opening as a draft for now and will convert to regular PR after finishing unit tests.
fixes #189