fix: check the type of dbt result when converting to markdown#16869
Merged
zzstoatzz merged 4 commits intoPrefectHQ:mainfrom Jan 28, 2025
dominictarro:fix/prefect-dbt-summary-artifact-markdown
Merged
fix: check the type of dbt result when converting to markdown#16869zzstoatzz merged 4 commits intoPrefectHQ:mainfrom dominictarro:fix/prefect-dbt-summary-artifact-markdown
zzstoatzz merged 4 commits intoPrefectHQ:mainfrom
dominictarro:fix/prefect-dbt-summary-artifact-markdown
Conversation
trigger_dbt_cli_command will respond with more than one type depending on the command invoked. This change uses the appropriate var depending on that result type.
From a test run
```
## Successful Nodes ✅
* unique_id=macro.dbt_external_tables.stage_external_sources message=None relation_name=None adapter_response={}
```
dominictarro
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
zzstoatzz
requested changes
Jan 28, 2025
Collaborator
zzstoatzz
left a comment
zzstoatzz
left a comment
There was a problem hiding this comment.
thanks @dominictarro for the PR! this makes sense to me, though I think we'll need to change the expectation of this failing test: test_run_dbt_source_freshness_creates_artifact
Contributor
Author
|
@zzstoatzz ready to rock |
zzstoatzz
approved these changes
Jan 28, 2025
Collaborator
zzstoatzz
left a comment
zzstoatzz
left a comment
There was a problem hiding this comment.
thanks @dominictarro !
zzstoatzz
added
integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16868
This change makes
create_summary_markdownuse different variables depending on the dbt command's output type.RunResult->.node.nameRunResultOutput->.unique_idChecklist
<link to issue>"mint.json.