Skip to content

fix: check the type of dbt result when converting to markdown #16869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzstoatzz merged 4 commits into from
Jan 28, 2025
Merged

fix: check the type of dbt result when converting to markdown #16869

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e97a427
fix: check the type of dbt result when converting to markdown
dominictarro Jan 27, 2025
0a0e50e
fix: changed to a better variable for discriminating the command
dominictarro Jan 27, 2025
41bb54b
refactor: swapped import order
dominictarro Jan 28, 2025
b8a900e
fix: support runs that output a FreshnessResult
dominictarro Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/integrations/prefect-dbt/prefect_dbt/cli/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from typing import Any, Dict, List, Optional, Union

import yaml
from dbt.artifacts.schemas.run.v5.run import RunResult, RunResultOutput
from dbt.cli.main import dbtRunner, dbtRunnerResult
from dbt.contracts.results import ExecutionResult, NodeStatus
from prefect_shell.commands import ShellOperation
Expand Down Expand Up @@ -864,9 +865,12 @@ def create_summary_markdown(run_results: dict, command: str) -> str:
markdown += _create_unsuccessful_markdown(run_results=run_results)

if run_results["Success"] != []:
successful_runs_str = "\n".join(
[f"* {r.node.name}" for r in run_results["Success"]]
)
successful_runs_str = ""
for r in run_results["Success"]:
if isinstance(r, RunResult):
successful_runs_str += f"* {r.node.name}\n"
elif isinstance(r, RunResultOutput):
successful_runs_str += f"* {r.unique_id}\n"
markdown += f"""\n## Successful Nodes ✅\n\n{successful_runs_str}\n\n"""

return markdown
Expand Down
Loading