Make .depend generation atomic and fail on coqdep errors#862
Open
JasonGross wants to merge 2 commits into
Open
Make .depend generation atomic and fail on coqdep errors#862JasonGross wants to merge 2 commits into
JasonGross wants to merge 2 commits into
Conversation
The main coqdep invocation was piped through grep with `|| true`, so a
coqdep that dies partway (e.g. killed under memory pressure, or hitting
a file-descriptor limit) silently left a truncated .depend; the
`.depend depend:` rule has no prerequisites, so later builds reuse the
poisoned file and parallel make compiles files before their
dependencies exist ("Unable to locate library ..." errors).
Write coqdep's output to a temporary file and move it into place only
on success. coqdep's stderr is still filtered live through grep (its
real exit status, otherwise hidden behind grep in the pipe, is
recovered through a status file since this recipe runs under POSIX sh
without pipefail).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019ttctspSoVoquHLQtbPVZw
coqdep in current Rocq dev leaks one file descriptor per located warning (fix proposed as rocq-prover/rocq#22278); over this tree's thousands of module-not-found warnings it dies with "Too many open files" under the common 1024 soft limit. Raise the soft limit to the hard limit for the coqdep invocation as a harmless workaround for affected Rocq versions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ttctspSoVoquHLQtbPVZw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some adjustments authored by Fable to make the coqdep step more robust, at the cost of making it less readable