Skip to content

Make .depend generation atomic and fail on coqdep errors #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JasonGross wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make .depend generation atomic and fail on coqdep errors #862

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a521fa
Make .depend generation atomic and fail on coqdep errors
JasonGross Jul 16, 2026
0712506
Raise the file descriptor soft limit when running coqdep
JasonGross Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,13 +913,29 @@ floyd/floyd.coq: floyd/proofauto.vo

.depend depend:
@echo 'coqdep ... >.depend'
# coqdep's dependency output is written to a temporary file and moved
# into place only if coqdep succeeds: a partial .depend (e.g. after
# coqdep is killed) would otherwise silently poison parallel builds with
# missing dependency edges. coqdep's stderr is still filtered live
# through grep; its real exit status is recovered through the pipe via a
# status file (this recipe runs under POSIX sh, which lacks pipefail).
ifeq ($(COMPCERT_NEW),true)
# DEPENDENCIES VARIANT COMPCERT_NEW
$(COQDEP) $(DEPFLAGS) 2>&1 >.depend `find $(filter $(wildcard *), $(DIRS) concurrency/common concurrency/compiler concurrency/juicy concurrency/util paco concurrency/sc_drf) -name "*.v"` | grep -v 'Warning:.*found in the loadpath' || true
@echo "" >>.depend
@ulimit -S -n `ulimit -H -n` 2>/dev/null || true; \
{ $(COQDEP) $(DEPFLAGS) `find $(filter $(wildcard *), $(DIRS) concurrency/common concurrency/compiler concurrency/juicy concurrency/util paco concurrency/sc_drf) -name "*.v"` 2>&1 >.depend-tmp; echo $$? >.depend-status; } | \
grep -v 'Warning:.*found in the loadpath' || true; \
st=`cat .depend-status`; rm -f .depend-status; \
[ "$$st" = 0 ] || { rm -f .depend-tmp; exit 1; }; \
echo "" >>.depend-tmp; \
mv .depend-tmp .depend
else
# DEPENDENCIES DEFAULT
$(COQDEP) $(DEPFLAGS) 2>&1 >.depend `find $(filter $(wildcard *), $(DIRS)) -name "*.v"` | grep -v 'Warning:.*found in the loadpath' || true
@ulimit -S -n `ulimit -H -n` 2>/dev/null || true; \
{ $(COQDEP) $(DEPFLAGS) `find $(filter $(wildcard *), $(DIRS)) -name "*.v"` 2>&1 >.depend-tmp; echo $$? >.depend-status; } | \
grep -v 'Warning:.*found in the loadpath' || true; \
st=`cat .depend-status`; rm -f .depend-status; \
[ "$$st" = 0 ] || { rm -f .depend-tmp; exit 1; }; \
mv .depend-tmp .depend
endif
ifeq ($(COMPCERT_BUILD_FROM_SRC),true)
# DEPENDENCIES TO BUILD COMPCERT FROM SOURCE
Expand Down