Use namespaced imports for Html class#36
Conversation
📝 Walkthrough""" WalkthroughThe changes update the import statements for the Changes
Estimated code review effort2 (~15 minutes) Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
GitHub Actions config needs update. Also good to bump the version of the extension to 4.0.0 and minimum MW version to 43 ( |
Fixes compatibility with MW 1.44. Raise MW requirement to 1.43 accordingly. Run CI on 1.44. Bump version to 4.0.0.
Should be done. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/ci.yml (1)
17-22: Quote thephpvalue to avoid YAML-float pitfalls and keep style consistentIn the test matrix the newly added entry uses an unquoted scalar (
php: 8.3) whereas the phpcs matrix below quotes the very same value ('8.3').
Quoting avoids the “8.0 → 8” truncation hazard seen when people later copy-paste this row for other versions and keeps the style uniform.- - mw: 'REL1_44' - php: 8.3 + - mw: 'REL1_44' + php: '8.3'README.md (1)
104-109: Release-note bullets violate the repo’s markdownlint style
markdownlintexpects dash (-) list markers, but the new entry uses asterisks (*), triggering MD004.-* Raised the minimum MediaWiki version from 1.39 to 1.43 +- Raised the minimum MediaWiki version from 1.39 to 1.43
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.github/workflows/ci.yml(1 hunks)README.md(2 hunks)extension.json(2 hunks)src/IconRenderers/JavascriptRenderer.php(1 hunks)src/IconRenderers/WebfontRenderer.php(1 hunks)tests/phpunit/IconRenderers/JavascriptRendererTest.php(1 hunks)tests/phpunit/IconRenderers/WebfontRendererTest.php(1 hunks)
🪛 markdownlint-cli2 (0.17.2)
README.md
108-108: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
✅ Files skipped from review due to trivial changes (3)
- extension.json
- src/IconRenderers/JavascriptRenderer.php
- tests/phpunit/IconRenderers/JavascriptRendererTest.php
🚧 Files skipped from review as they are similar to previous changes (2)
- tests/phpunit/IconRenderers/WebfontRendererTest.php
- src/IconRenderers/WebfontRenderer.php
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
108-108: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
🔇 Additional comments (1)
README.md (1)
14-16: Double-check that thecomposer.jsonalso enforces PHP ≥ 8.1 & MW ≥ 1.43The requirements table is updated, but if
composer.json(not shown here) still advertises lower constraints, users can install an incompatible version.
Please verify thatcomposer.jsonnow contains:"require": { "php": ">=8.1", "mediawiki/core": ">=1.43" }
MediaWiki 1.43 requires PHP 8.1.0.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
README.md (1)
104-110: Fix MD004 – unify list marker style inside the new release-notes block
markdownlintflags the two new bullets for using*while the surrounding lists in the “Requirements” section use-. Pick one marker style for the whole document. If you follow the linter recommendation (dash), the diff is trivial:-* Raised the minimum PHP version from 7.4.3 to 8.1.0 -* Raised the minimum MediaWiki version from 1.39 to 1.43 +- Raised the minimum PHP version from 7.4.3 to 8.1.0 +- Raised the minimum MediaWiki version from 1.39 to 1.43(Or flip the earlier dashes to stars—either way, be consistent.)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(2 hunks)
🪛 markdownlint-cli2 (0.17.2)
README.md
108-108: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
109-109: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
108-108: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
109-109: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
| - PHP 8.1.0 or later | ||
| - MediaWiki 1.43 or later |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Composer example still references the obsolete ^2.0 constraint
The requirements were bumped to PHP 8.1 / MW 1.43, yet the Composer install snippet further down the file still asks for ^2.0. Anyone copy-pasting it will end up installing an old major version that does not match the documented requirements.
-1. `COMPOSER=composer.local.json php composer.phar require --no-update mediawiki/font-awesome ^2.0`
+1. `COMPOSER=composer.local.json php composer.phar require --no-update mediawiki/font-awesome ^4.0`🏁 Script executed:
#!/bin/bash
# Search for the composer require snippet in README.md
grep -n 'composer.phar require' README.md
# Check if the old ^2.0 constraint is still referenced
grep -n '\^2\.0' README.mdLength of output: 278
🏁 Script executed:
#!/bin/bash
# Fetch the latest 10 versions of mediawiki/font-awesome from Packagist
curl -s https://packagist.org/packages/mediawiki/font-awesome.json \
| grep -o '"version":"[^"]*"' \
| sed 's/"version":"//; s/"//' \
| sort -rV \
| head -n 10
# List all unique major versions available
curl -s https://packagist.org/packages/mediawiki/font-awesome.json \
| grep -o '"version":"[^"]*"' \
| sed 's/"version":"//; s/"//' \
| cut -d'.' -f1 \
| sort -uLength of output: 387
Update Composer constraint to the latest major (3.x)
The README’s install snippet still pins ^2.0, but Packagist’s newest stable major release is 3.0.0. Copy-pasting the old constraint will pull in v2.x instead of the current v3.x.
– README.md, line 25:
- COMPOSER=composer.local.json php composer.phar require --no-update mediawiki/font-awesome ^2.0
+ COMPOSER=composer.local.json php composer.phar require --no-update mediawiki/font-awesome ^3.0Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In README.md around lines 14 to 15, the Composer version constraint is outdated,
still pinned to ^2.0, which causes installation of version 2.x instead of the
latest major 3.x. Update the Composer constraint in the install snippet to ^3.0
to ensure users get the current stable major release.
3 participants
Fixes compatibility with MW 1.44.
Raise MW requirement to 1.40 accordingly.
Summary by CodeRabbit
No changes to user-facing features or functionality.