Skip to content

Use namespaced imports for Html class #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malberts merged 3 commits into from
Jul 23, 2025
Merged

Use namespaced imports for Html class #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bee93c
Use namespaced imports for Html class
SomeMWDev Jul 22, 2025
08b37a1
Bump PHP requirement to 8.1.0
SomeMWDev Jul 22, 2025
bdc6774
Mention PHP version requirement change in changelog
SomeMWDev Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,12 @@ jobs:
strategy:
matrix:
include:
- mw: 'REL1_39'
php: 7.4
experimental: false
- mw: 'REL1_40'
php: 8.0
experimental: false
- mw: 'REL1_41'
php: 8.1
experimental: false
- mw: 'REL1_42'
php: 8.2
experimental: false
- mw: 'REL1_43'
php: 8.3
experimental: false
- mw: 'REL1_44'
php: 8.3
experimental: false

runs-on: ubuntu-latest

Expand Down
11 changes: 9 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ Currently Font Awesome Free version 6.7.2 is included.

## Requirements

- PHP 7.4.3 or later
- MediaWiki 1.39 or later
- PHP 8.1.0 or later
Comment thread
SomeMWDev marked this conversation as resolved.
- MediaWiki 1.43 or later
Comment on lines +14 to +15

@coderabbitai coderabbitai Bot Jul 22, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Composer example still references the obsolete ^2.0 constraint

The requirements were bumped to PHP 8.1 / MW 1.43, yet the Composer install snippet further down the file still asks for ^2.0. Anyone copy-pasting it will end up installing an old major version that does not match the documented requirements.

-1. `COMPOSER=composer.local.json php composer.phar require --no-update mediawiki/font-awesome ^2.0`
+1. `COMPOSER=composer.local.json php composer.phar require --no-update mediawiki/font-awesome ^4.0`

🏁 Script executed:

#!/bin/bash
# Search for the composer require snippet in README.md
grep -n 'composer.phar require' README.md

# Check if the old ^2.0 constraint is still referenced
grep -n '\^2\.0' README.md

Length of output: 278

🏁 Script executed:

#!/bin/bash
# Fetch the latest 10 versions of mediawiki/font-awesome from Packagist
curl -s https://packagist.org/packages/mediawiki/font-awesome.json \
  | grep -o '"version":"[^"]*"' \
  | sed 's/"version":"//; s/"//' \
  | sort -rV \
  | head -n 10

# List all unique major versions available
curl -s https://packagist.org/packages/mediawiki/font-awesome.json \
  | grep -o '"version":"[^"]*"' \
  | sed 's/"version":"//; s/"//' \
  | cut -d'.' -f1 \
  | sort -u

Length of output: 387

Update Composer constraint to the latest major (3.x)

The README’s install snippet still pins ^2.0, but Packagist’s newest stable major release is 3.0.0. Copy-pasting the old constraint will pull in v2.x instead of the current v3.x.

– README.md, line 25:

- COMPOSER=composer.local.json php composer.phar require --no-update mediawiki/font-awesome ^2.0
+ COMPOSER=composer.local.json php composer.phar require --no-update mediawiki/font-awesome ^3.0

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In README.md around lines 14 to 15, the Composer version constraint is outdated,
still pinned to ^2.0, which causes installation of version 2.x instead of the
latest major 3.x. Update the Composer constraint in the install snippet to ^3.0
to ensure users get the current stable major release.


## Installation

Expand Down Expand Up @@ -101,6 +101,13 @@ The Font Awesome Free package is included in the extension. See its

## Release notes

### Version 4.0.0

Released on July 22, 2025.

* Raised the minimum PHP version from 7.4.3 to 8.1.0
* Raised the minimum MediaWiki version from 1.39 to 1.43

### Version 3.0.0

Released on March 15, 2025.
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"issues": "https://github.com/ProfessionalWiki/FontAwesome/issues"
},
"require": {
"php": ">=7.4.3",
"php": ">=8.1",
"composer/installers": "^2|^1.0.1"
},
"require-dev": {
Expand Down
4 changes: 2 additions & 2 deletions extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "FontAwesome",
"version": "3.0.0",
"version": "4.0.0",
"type": "other",
"author": [
"[https://www.mediawiki.org/wiki/User:F.trott Stephan Gambke]",
Expand All @@ -10,7 +10,7 @@
"descriptionmsg": "fontawesome-desc",
"license-name": "GPL-3.0-or-later",
"requires": {
"MediaWiki": ">=1.39"
"MediaWiki": ">=1.43"
},
"MessagesDirs": {
"FontAwesome": "i18n"
Expand Down
2 changes: 1 addition & 1 deletion src/IconRenderers/JavascriptRenderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

namespace FontAwesome\IconRenderers;

use Html;
use MediaWiki\Html\Html;
use Parser;
use PPFrame;

Expand Down
2 changes: 1 addition & 1 deletion src/IconRenderers/WebfontRenderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

namespace FontAwesome\IconRenderers;

use Html;
use MediaWiki\Html\Html;
use Parser;
use PPFrame;

Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/IconRenderers/JavascriptRendererTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

use FontAwesome\IconRenderers\IconRenderer;
use FontAwesome\IconRenderers\JavascriptRenderer;
use Html;
use MediaWiki\Html\Html;
use Parser;
use ParserOutput;
use PHPUnit\Framework\TestCase;
Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/IconRenderers/WebfontRendererTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

use FontAwesome\IconRenderers\IconRenderer;
use FontAwesome\IconRenderers\WebfontRenderer;
use Html;
use MediaWiki\Html\Html;
use Parser;
use ParserOutput;
use PHPUnit\Framework\TestCase;
Expand Down