Skip to content

Address nightly build failure#618

Merged
jukent merged 6 commits intoProjectPythia:mainfrom
jukent:jukent-patch-1
Mar 10, 2026
Merged

Address nightly build failure#618
jukent merged 6 commits intoProjectPythia:mainfrom
jukent:jukent-patch-1

Conversation

@jukent
Copy link
Copy Markdown
Contributor

@jukent jukent commented Mar 4, 2026

It looks like one of our dependencies dropped pytz as a dependency and now it is no longer in the environment causing our nightly build to fail.

Likely unrelated to pytz's release yesterday but some other package's release. Interestingly pytz says, "Note
Projects using Python 3.9 or later should be using the support now included as part of the standard library, and third party packages work with it such as tzdata. pytz offers no advantages beyond backwards compatibility with code written for earlier versions of Python."

Should we consider using Python's built-in zoneinfo instead? @dcamron you added this section 5+ years ago to the datetime chapter, what are your thoughts?

@jukent jukent requested a review from dcamron March 4, 2026 15:17
@jukent jukent requested a review from a team as a code owner March 4, 2026 15:17
@jukent jukent requested review from brian-rose and removed request for a team March 4, 2026 15:17
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2026

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 55cedca
✅ Deployment Preview URL: https://ProjectPythia.github.io/pythia-foundations/_preview/618

@jukent
Copy link
Copy Markdown
Contributor Author

jukent commented Mar 4, 2026

Interesting this is failing with checks that we didn't catch before:

I'll address these in a push soon.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@brian-rose
Copy link
Copy Markdown
Member

Should we consider using Python's built-in zoneinfo instead? @dcamron you added this section 5+ years ago to the datetime chapter, what are your thoughts?

I would say yes! I wasn't aware of this, but I don't think it's good for the code examples in Foundations to be propagating outdated ways of doing things. We don't have any mandate to support backwards compatibility here!

@dcamron
Copy link
Copy Markdown
Contributor

dcamron commented Mar 4, 2026

Yes, we have been using datetime.timezone and datetime.UTC (a shortcut) for a while on Unidata projects. Never thought to come check over here, but I have time to go start a review now, and I can remove the pytz dependency in that PR we should be fine without pytz from there.

@dcamron dcamron mentioned this pull request Mar 10, 2026
@jukent jukent changed the title Update environment.yml Address nightly build failure Mar 10, 2026
@jukent jukent merged commit cf5d415 into ProjectPythia:main Mar 10, 2026
3 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 10, 2026
kafitzgerald pushed a commit to kafitzgerald/pythia-foundations that referenced this pull request Mar 30, 2026
* Update environment.yml

* add header targets

* jupyterbook link fails jupyterbooks link checking :P

* Update environment.yml

* 3 links
kafitzgerald pushed a commit to kafitzgerald/pythia-foundations that referenced this pull request Mar 30, 2026
* Update environment.yml

* add header targets

* jupyterbook link fails jupyterbooks link checking :P

* Update environment.yml

* 3 links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants