Address nightly build failure#618
Conversation
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
|
Interesting this is failing with checks that we didn't catch before:
I'll address these in a push soon. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I would say yes! I wasn't aware of this, but I don't think it's good for the code examples in Foundations to be propagating outdated ways of doing things. We don't have any mandate to support backwards compatibility here! |
|
Yes, we have been using |
* Update environment.yml * add header targets * jupyterbook link fails jupyterbooks link checking :P * Update environment.yml * 3 links
* Update environment.yml * add header targets * jupyterbook link fails jupyterbooks link checking :P * Update environment.yml * 3 links
It looks like one of our dependencies dropped
pytzas a dependency and now it is no longer in the environment causing our nightly build to fail.Likely unrelated to
pytz's release yesterday but some other package's release. Interestinglypytzsays, "NoteProjects using Python 3.9 or later should be using the support now included as part of the standard library, and third party packages work with it such as tzdata. pytz offers no advantages beyond backwards compatibility with code written for earlier versions of Python."
Should we consider using Python's built-in
zoneinfoinstead? @dcamron you added this section 5+ years ago to the datetime chapter, what are your thoughts?