BYOC_ID: 46026 - Refactor hhg#1321
Open
lizihao-anu wants to merge 18 commits into
Open
Conversation
lizihao-anu
added
BYOC
PR ready for review
On hold
This was
linked to
issues
May 4, 2026
Jennit07
added
Preprod data available
Preprod data not available
and removed
Preprod data available
labels
Jennit07
reviewed
Jun 8, 2026
Comment on lines
+46
to
+62
| get_sparra_path <- function(year, BYOC_MODE, ...) { | ||
| if (!check_year_valid(year, "sparra")) { | ||
| return(get_dummy_boxi_extract_path()) | ||
| } | ||
|
|
||
| sparra_file_path <- get_file_path( | ||
| directory = fs::path(get_slf_dir(), "SPARRA"), | ||
| file_name = stringr::str_glue("anon-SPARRA-20{year}.parquet"), | ||
| ... | ||
| ) | ||
| if (isTRUE(BYOC_MODE)) { | ||
| hhg_file_path <- file.path( | ||
| denodo_output_path(), | ||
| stringr::str_glue("anon-SPARRA-20{year}.parquet") | ||
| ) | ||
| } else { | ||
| sparra_file_path <- get_file_path( | ||
| directory = fs::path(get_slf_dir(), "SPARRA"), | ||
| file_name = stringr::str_glue("anon-SPARRA-20{year}.parquet"), | ||
| ... | ||
| ) | ||
| } |
Collaborator
There was a problem hiding this comment.
Please see draft PR for agreed refactoring format: #1336
Collaborator
|
Update: JT to split out HHG and SPARRA. WIP on branches:
|
Collaborator
|
Summary of changes:
TODO:
This PR is ready for checking/PHS testing @lizihao-anu |
lizihao-anu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined two tickets together