BYOC_ID: 46016 - Refactor SPARRA#1336
Open
Jennit07 wants to merge 10 commits into
Open
Conversation
Jennit07
commented
Jun 9, 2026
Comment on lines
+64
to
+76
| get_sparra_data <- function(year, | ||
| denodo_connect = get_denodo_connection(BYOC_MODE = BYOC_MODE), | ||
| BYOC_MODE) { | ||
| if (isTRUE(BYOC_MODE)) { | ||
| extract_sparra <- dplyr::tbl( | ||
| denodo_connect, | ||
| dbplyr::in_schema("sdl", "sdl_sparra_source") | ||
| ) %>% | ||
| ## TODO: Check filters/sparra risk year ## | ||
| collect() | ||
| } else { | ||
| extract_sparra <- read_file(get_sparra_path(year)) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Discussed with LB: Should we always read from Denodo if BYOC_MODE is TRUE/FALSE
Collaborator
Author
|
Summary:
TODO:
PR is ready for checking/PHS testing |
Jennit07
added
the
On hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out content from #1321
SPARRA refactoring - risk date must be calculated from 1st April for the financial year. This is a projection score. e.g. 01/04/2025 would be included in the 2025/26 financial year.