This repository was archived by the owner on Nov 7, 2025. It is now read-only.
[sample_flights, quickfix] Add doc_count = 0 if no DB result in filter
#1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trzysiek
changed the title
sample_flights] Add doc_count = 0 to filter if no results from DBsample_flights] Quickfix add doc_count = 0 if no DB result in filter
trzysiek
changed the title
sample_flights] Quickfix add doc_count = 0 if no DB result in filtersample_flights, quickfix] Add doc_count = 0 if no DB result in filter
jakozaur
approved these changes
Mar 3, 2025
Contributor
jakozaur
left a comment
jakozaur
left a comment
There was a problem hiding this comment.
Please just add two comments.
platform/parsers/elastic_query_dsl/pancake_sql_query_generation_test.go
Outdated
Show resolved
Hide resolved
platform/parsers/elastic_query_dsl/pancake_sql_query_generation_test.go
Outdated
Show resolved
Hide resolved
Member
|
/run-integration-tests |
Deploying quesma with
|
| Latest commit: |
124b562
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://be80fbb7.quesma.pages.dev |
| Branch Preview URL: | https://sample-flights-1.quesma.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds all requests from
flightsas tests. I think they all pass, but I need to update results in last 2 of them.