Skip to content

Implement ViewTransition in v2 #7391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: build/v2
Choose a base branch
from

Conversation

GrandSchtroumpf
Copy link
Contributor

@GrandSchtroumpf GrandSchtroumpf commented Mar 3, 2025

What is it?

Feature / enhancement

Description

Implement ViewTransition in v2 including:

  • emitting qviewTransition
  • add missing types for ViewTransition API from current typescript version
  • disable view-transition-name only for specific type if available

Note: Some of the types used here are not release in any typescript version yet.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@GrandSchtroumpf GrandSchtroumpf requested a review from a team as a code owner March 3, 2025 08:31
Copy link

changeset-bot bot commented Mar 3, 2025

🦋 Changeset detected

Latest commit: d64badc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/router Patch
eslint-plugin-qwik Patch
@qwik.dev/core Patch
create-qwik Patch
@qwik.dev/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but unfortunately it breaks one of the e2e tests. Not sure if it's due to the test or due to the added CSS?

Copy link
Contributor

github-actions bot commented Apr 6, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview d64badc

@wmertens
Copy link
Member

wmertens commented Apr 6, 2025

@GrandSchtroumpf so the breaking test is for scroll restoration. Could you have a look? You can manually run pnpm serve and then go to /qwikrouter-test/scroll-restoration/page-short and repeat the actions of the test to figure out what's going wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants