-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Implement ViewTransition in v2 #7391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: build/v2
Are you sure you want to change the base?
Implement ViewTransition in v2 #7391
Conversation
🦋 Changeset detectedLatest commit: d64badc The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great but unfortunately it breaks one of the e2e tests. Not sure if it's due to the test or due to the added CSS?
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
@GrandSchtroumpf so the breaking test is for scroll restoration. Could you have a look? You can manually run |
What is it?
Feature / enhancement
Description
Implement ViewTransition in v2 including:
Note: Some of the types used here are not release in any typescript version yet.
Checklist
pnpm change