chore: merge main into v2 #7443
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: dispatch q:viewTransition when started * add changeset * add documentation * replace q:viewTransition for qviewTransition * move QwikTransitionEvent up * doc: fix example * doc: improve examples * doc: expose new page * doc: add indication about ViewTransition interface * doc: fix doc typo and add explaination
* deprecated eagerness * reviewd changes * added changeset
* feat: add ErrorBoundary component and update error handling in Qwik City * fix: update error boundary handling in Qwik City and Qwik * fix: improve ErrorBoundary handling and update useErrorBoundary return value
Fix: Windows Docs.dev script
* handle hmr and css importer persistence * changeset
* fix: pass server$ errors through to middleware * fix e2e tests * Add changeset * Add middlewaare error test and remove ErrorResponse * Update changeset * Add error handling docs * Allow returning plain text ServerErrors * Improvements * Update docs * test server errors with text/html accept headers * Update changesets * Update ErrorResponse and vite bug url
…ebug-mode refactor(rollup): move build mode + debug:true chunk names logic out of manualChunks
fix(eslint-plugin-qwik): fix ESLint 9 compatibility, enhance README
fix: vscode vitest error
#7420) * When csr is true, it causes a crash because resolve cannot be null as the second parameter * Create cyan-deers-glow.md --------- Co-authored-by: wuls <[email protected]>
…ptionsObject-2 refactor(rollup): normalizeRollupOutputOptionsObject to accept qwikPlugin as an argument
…rnal hooks. (#7366) * fix: a bug is about qwik ts error * When it is a Qwik hook, there is no need for recursive lookup. * Create wicked-dolphins-boil.md * modify comment --------- Co-authored-by: wuls <[email protected]>
* chore: migrate build.clean fow windows support * chore: migrate docs.preview command for windows support
* removed rehype-pretty-code and replaced with shiki * fix * fix
|
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Varixo
reviewed
Mar 21, 2025
Comment on lines
+10
to
+19
| let __dirname = path.dirname(fileURLToPath(import.meta.url)); | ||
| const isWindows = process.platform === 'win32'; | ||
| if (isWindows && __dirname.startsWith('/')) { | ||
| // in Windows __dirname starts with a / causing errors | ||
| // before | ||
| // /C:/Users/{location stuff}/qwik/packages/docs | ||
| __dirname = __dirname.substring(1); | ||
| // after | ||
| // C:/Users/{location stuff}/qwik/packages/docs | ||
| } |
There was a problem hiding this comment.
not sure if this is needed. I fixed it in v2 and worked without any problem for me on Windows. I can check it later today
There was a problem hiding this comment.
it works but the old way is also working
| @@ -52,6 +53,7 @@ | |||
| - [Sync events w state](/docs/cookbook/sync-events/index.mdx) | |||
| - [Theme Management](/docs/cookbook/theme-management/index.mdx) | |||
| - [Drag & Drop](/docs/cookbook/drag&drop/index.mdx) | |||
| - [View Transition](/docs/cookbook/view-transition/index.mdx) | |||
Comment on lines
+19
to
+20
| /** Emitted by qwik-core on document when the a view transition start @public */ | ||
| export type QwikViewTransitionEvent = CustomEvent<ViewTransition>; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not include the viewtransition changes which will need a separate PR, cc @GrandSchtroumpf .
Also, types are somewhat broken, to be fixed.