Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge main into v2 #7443

Open
wants to merge 36 commits into
base: build/v2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
73e8fcc
feat: View Transition hook (#7237)
GrandSchtroumpf Feb 28, 2025
07a45f4
deprecated useTask$ eagerness (#7345)
sreeisalso Mar 1, 2025
e56fa22
fix check builds add windows support
Shane-Donlon Mar 2, 2025
38d98ca
revert dev script to remove race condition
Shane-Donlon Mar 2, 2025
f613bd2
fix docs.dev cd on windows
Shane-Donlon Mar 2, 2025
dc26aef
refactor: windows dirname variable check
Shane-Donlon Mar 2, 2025
d6b66d9
tests: fix setupEsLintRuleTesters path for windows
Shane-Donlon Mar 2, 2025
a8a1d13
fix: error boundary (#7342)
damianpumar Mar 2, 2025
c51aaab
Merge pull request #7388 from Shane-Donlon/fix-windowsdocs.dev
Varixo Mar 3, 2025
68b2bd9
dev server: handle hmr and css importer persistence (#7389)
thejackshelton Mar 4, 2025
5282a39
fix: standardise error handling (#7185)
DustinJSilk Mar 4, 2025
d0884d6
chore(starters): correct Auth optimizeDeps instructions (#7398)
Shane-Donlon Mar 6, 2025
d297d3e
feat(cli): add ability to keep using tailwind v3 (#7403)
maiieul Mar 11, 2025
f8853c2
refactor(rollup): move build mode + debug:true chunk names logic out …
maiieul Mar 11, 2025
c4088aa
refactor: extract sanitizePath
maiieul Mar 11, 2025
7bf156d
refactor: assign sanitizedPath to chunkInfo.name and return it
maiieul Mar 11, 2025
63c0b63
test: refactor for chunkFileNames and entryFileNames as functions
maiieul Mar 11, 2025
6539637
test: fix types
maiieul Mar 11, 2025
9d5679d
test: fix e2e
maiieul Mar 12, 2025
8f05cfc
test: fix CI using cwd
maiieul Mar 12, 2025
1d28b7c
Merge pull request #7412 from maiieul/better-preview-chunk-names-in-d…
wmertens Mar 12, 2025
133a7cb
fix(repl): on repl fileName chunkInfo has modules but not moduleIds (…
maiieul Mar 12, 2025
dc37d9d
fix(eslint-plugin-qwik): fix ESLint 9 compatibility, improve typing a…
better-salmon Mar 12, 2025
68cb534
Merge pull request #7415 from better-salmon/fix-eslint-plugin-qwik
wmertens Mar 12, 2025
3951018
fix
sreeisalso Mar 14, 2025
c5626c8
Merge pull request #7421 from sreeisalso/vscode-vitest
wmertens Mar 14, 2025
1ca63f8
When csr is true, it causes a crash because resolve cannot be null as…
JerryWu1234 Mar 14, 2025
0cf1eaf
Merge pull request #7413 from maiieul/refactor-normalizeRollupOutputO…
maiieul Mar 14, 2025
5cab0e9
Fix: Enhance lexical scope and skip variables declared by Qwik's inte…
JerryWu1234 Mar 14, 2025
62e5f9a
chore(scripts): improve windows support (#7399)
Shane-Donlon Mar 14, 2025
a67c3be
docs: remove rehype and replace with shiki (#7385)
sreeisalso Mar 14, 2025
cffd700
fix(docs): fix up minor typos (#7434)
compusophy Mar 17, 2025
bb29629
fix(merge): typescript, api-extractor, etc
wmertens Mar 20, 2025
624b968
fix(public core): re-export some missing types
wmertens Mar 20, 2025
e1fd8d3
Merge remote-tracking branch 'origin/build/v2' into v2-merge-main
wmertens Mar 20, 2025
bd251be
fixup
wmertens Mar 21, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
**/api.md
**/*.api.md
**/*.log
**/.DS_Store
*.
Expand Down
16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@
"@clack/prompts": "0.7.0",
"@eslint/eslintrc": "3.1.0",
"@mdx-js/mdx": "3.0.1",
"@microsoft/api-documenter": "7.24.2",
"@microsoft/api-extractor": "7.43.1",
"@microsoft/api-documenter": "7.26.17",
"@microsoft/api-extractor": "7.52.1",
"@napi-rs/cli": "2.18.4",
"@napi-rs/triples": "1.2.0",
"@node-rs/helper": "1.6.0",
Expand Down Expand Up @@ -150,12 +150,12 @@
"tmp": "0.2.3",
"tree-kill": "1.2.2",
"tsx": "4.19.2",
"typescript": "5.4.5",
"typescript": "5.8.2",
"vfile": "6.0.2",
"vite": "5.4.10",
"vite-imagetools": "7.0.4",
"vite-plugin-dts": "4.3.0",
"vite-tsconfig-paths": "5.0.1",
"vite-tsconfig-paths": "5.1.4",
"vitest": "3.0.8",
"watchlist": "0.3.1",
"which-pm-runs": "1.1.0",
Expand All @@ -170,7 +170,7 @@
"packageManager": "[email protected]",
"pnpm": {
"overrides": {
"typescript": "5.4.5",
"typescript": "5.8.2",
"vfile": "6.0.2",
"@supabase/realtime-js": "2.8.4"
},
Expand All @@ -183,7 +183,7 @@
"api.update": "tsx --require ./scripts/runBefore.ts scripts/index.ts --tsc --api --dev",
"build": "tsx --require ./scripts/runBefore.ts scripts/index.ts",
"build.changelog-formatter": "tsc .changeset/changelog-github-custom.ts && mv .changeset/changelog-github-custom.js .changeset/changelog-github-custom.cjs",
"build.clean": "rm -rf packages/qwik/dist/ && rm -rf packages/qwik-router/lib/ && rm -rf packages/docs/dist/ && rm -rf packages/insights/dist/",
"build.clean": "tsx ./scripts/build-clean.ts",
"build.cli": "tsx --require ./scripts/runBefore.ts scripts/index.ts --cli --dev",
"build.cli.prod": "tsx --require ./scripts/runBefore.ts scripts/index.ts --cli",
"build.core": "tsx --require ./scripts/runBefore.ts scripts/index.ts --tsc --qwik --insights --qwikrouter --api --platform-binding",
Expand All @@ -205,8 +205,8 @@
"cli.qwik": "pnpm build.cli && node packages/qwik/qwik-cli.cjs",
"cli.validate": "tsx --require ./scripts/runBefore.ts scripts/validate-cli.ts",
"deps": "corepack pnpm upgrade -i -r --latest && syncpack fix-mismatches && corepack pnpm dedupe",
"docs.dev": "cd packages/docs && pnpm build.repl-sw && pnpm dev",
"docs.preview": "cd packages/docs && pnpm preview",
"docs.dev": "pnpm -C packages/docs build.repl-sw && pnpm -C packages/docs dev",
"docs.preview": "pnpm -C packages/docs preview",
"docs.sync": "tsx --require ./scripts/runBefore.ts scripts/docs_sync/index.ts && pnpm fmt",
"eslint.update": "tsx --require ./scripts/runBefore.ts scripts/eslint-docs.ts",
"fmt": "pnpm prettier.fix && pnpm syncpack format",
Expand Down
18 changes: 14 additions & 4 deletions packages/docs/check-qwik-build.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,22 @@
// verify that ../qwik/dist/core.d.ts exists or run `pnpm run build.core` in the root directory
// Also make sure that the repl-sw.js file is present, for dev mode
// we need it for development and for the REPL
import fs from 'fs';
import path from 'path';
import { spawnSync } from 'child_process';

import fs from 'node:fs';
import path from 'node:path';
import { spawnSync } from 'node:child_process';
import { fileURLToPath } from 'url';

const __dirname = path.dirname(fileURLToPath(import.meta.url));
let __dirname = path.dirname(fileURLToPath(import.meta.url));
const isWindows = process.platform === 'win32';
if (isWindows && __dirname.startsWith('/')) {
// in Windows __dirname starts with a / causing errors
// before
// /C:/Users/{location stuff}/qwik/packages/docs
__dirname = __dirname.substring(1);
// after
// C:/Users/{location stuff}/qwik/packages/docs
}
Comment on lines +10 to +19
Copy link
Member

@Varixo Varixo Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is needed. I fixed it in v2 and worked without any problem for me on Windows. I can check it later today

Copy link
Member

@Varixo Varixo Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works but the old way is also working

const qwikPkgDir = path.join(__dirname, '..', 'qwik', 'dist');

if (!fs.existsSync(path.join(qwikPkgDir, 'core-internal.d.ts'))) {
Expand Down
11 changes: 7 additions & 4 deletions packages/docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@
"@qwik.dev/core": "workspace:*",
"@qwik.dev/react": "workspace:*",
"@qwik.dev/router": "workspace:*",
"@shikijs/colorized-brackets": "3.1.0",
"@shikijs/rehype": "3.1.0",
"@shikijs/transformers": "3.1.0",
"@shikijs/types": "3.1.0",
"@supabase/supabase-js": "2.44.4",
"@types/leaflet": "1.9.12",
"@types/prismjs": "1.26.4",
Expand All @@ -44,13 +48,12 @@
"qwik-image": "0.0.16",
"react": "18.3.1",
"react-dom": "18.3.1",
"rehype-pretty-code": "0.14.0",
"shiki": "1.29.1",
"shiki": "3.1.0",
"snarkdown": "2.0.0",
"tailwindcss": "3.4.6",
"terser": "5.37.0",
"tsm": "2.3.0",
"typescript": "5.4.5",
"typescript": "5.8.2",
"undici": "*",
"valibot": "0.33.3",
"vite": "5.4.10",
Expand All @@ -76,7 +79,7 @@
"codesandbox.sync": "tsx codesandbox.sync.ts",
"contributors": "tsx contributors.ts",
"deploy": "wrangler pages publish ./dist",
"dev": "concurrently \"tsx check-qwik-build.ts\" \"vite --mode ssr --open\"",
"dev": "tsx check-qwik-build.ts && vite --mode ssr --open",
"dev.debug": "node --inspect-brk ../../node_modules/vite/bin/vite.js --mode ssr --force",
"prebuild.core": "tsx check-qwik-build.ts",
"preview": "qwik build preview && vite preview --open",
Expand Down
7 changes: 1 addition & 6 deletions packages/docs/src/components/code-sandbox/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,7 @@ export default component$<{
))}
</div>
)}
<div
class="overflow-auto slot-container mb-4"
style={{
'--pretty-code-fragment-max-height': maxHeight ? maxHeight + 'px' : 'none',
}}
>
<div class="overflow-auto slot-container mb-4">
<Slot name={tabs ? String(activeTab.value) : ''} />
</div>
<div class="browser shadow-xl">
Expand Down
2 changes: 1 addition & 1 deletion packages/docs/src/components/qwik-gpt/index.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { component$, useComputed$, useSignal } from '@qwik.dev/core';
// import { qwikGPT, rateResponse } from './search';
import { CodeBlock } from '../code-block/code-block';
// import { isBrowser } from '@builder.io/qwik';
// import { isBrowser } from '@qwik.dev/core';
import snarkdown from 'snarkdown';

const snarkdownEnhanced = (md: string) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ For example, here's how we use a Qwik counter component in Astro.
**counter.tsx**

```tsx
import { component$, useSignal } from "@builder.io/qwik";
import { component$, useSignal } from "@qwik.dev/core";

export const Counter = component$(() => {
const counter = useSignal(0);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
}
],
"kind": "Function",
"content": "```typescript\nexport declare function createQwikRouter(opts: AwsOpt): {\n fixPath: (pathT: string) => string;\n router: (req: import(\"http\").IncomingMessage | import(\"http2\").Http2ServerRequest, res: import(\"http\").ServerResponse<import(\"http\").IncomingMessage>, next: import(\"@qwik.dev/router/middleware/node\").NodeRequestNextFunction) => Promise<void>;\n staticFile: (req: import(\"http\").IncomingMessage | import(\"http2\").Http2ServerRequest, res: import(\"http\").ServerResponse<import(\"http\").IncomingMessage>, next: (e?: any) => void) => Promise<void>;\n notFound: (req: import(\"http\").IncomingMessage | import(\"http2\").Http2ServerRequest, res: import(\"http\").ServerResponse<import(\"http\").IncomingMessage>, next: (e: any) => void) => Promise<void>;\n handle: (req: any, res: any) => void;\n};\n```\n\n\n<table><thead><tr><th>\n\nParameter\n\n\n</th><th>\n\nType\n\n\n</th><th>\n\nDescription\n\n\n</th></tr></thead>\n<tbody><tr><td>\n\nopts\n\n\n</td><td>\n\nAwsOpt\n\n\n</td><td>\n\n\n</td></tr>\n</tbody></table>\n**Returns:**\n\n{ fixPath: (pathT: string) =&gt; string; router: (req: import(\"http\").IncomingMessage \\| import(\"http2\").Http2ServerRequest, res: import(\"http\").ServerResponse&lt;import(\"http\").IncomingMessage&gt;, next: import(\"@qwik.dev/router/middleware/node\").NodeRequestNextFunction) =&gt; Promise&lt;void&gt;; staticFile: (req: import(\"http\").IncomingMessage \\| import(\"http2\").Http2ServerRequest, res: import(\"http\").ServerResponse&lt;import(\"http\").IncomingMessage&gt;, next: (e?: any) =&gt; void) =&gt; Promise&lt;void&gt;; notFound: (req: import(\"http\").IncomingMessage \\| import(\"http2\").Http2ServerRequest, res: import(\"http\").ServerResponse&lt;import(\"http\").IncomingMessage&gt;, next: (e: any) =&gt; void) =&gt; Promise&lt;void&gt;; handle: (req: any, res: any) =&gt; void; }",
"content": "```typescript\nexport declare function createQwikRouter(opts: AwsOpt): {\n fixPath: (pathT: string) => string;\n router: (req: import(\"http\").IncomingMessage | import(\"http2\").Http2ServerRequest, res: import(\"http\").ServerResponse, next: import(\"@qwik.dev/router/middleware/node\").NodeRequestNextFunction) => Promise<void>;\n staticFile: (req: import(\"http\").IncomingMessage | import(\"http2\").Http2ServerRequest, res: import(\"http\").ServerResponse, next: (e?: any) => void) => Promise<void>;\n notFound: (req: import(\"http\").IncomingMessage | import(\"http2\").Http2ServerRequest, res: import(\"http\").ServerResponse, next: (e: any) => void) => Promise<void>;\n handle: (req: any, res: any) => void;\n};\n```\n\n\n<table><thead><tr><th>\n\nParameter\n\n\n</th><th>\n\nType\n\n\n</th><th>\n\nDescription\n\n\n</th></tr></thead>\n<tbody><tr><td>\n\nopts\n\n\n</td><td>\n\nAwsOpt\n\n\n</td><td>\n\n\n</td></tr>\n</tbody></table>\n**Returns:**\n\n{ fixPath: (pathT: string) =&gt; string; router: (req: import(\"http\").IncomingMessage \\| import(\"http2\").Http2ServerRequest, res: import(\"http\").ServerResponse, next: import(\"@qwik.dev/router/middleware/node\").NodeRequestNextFunction) =&gt; Promise&lt;void&gt;; staticFile: (req: import(\"http\").IncomingMessage \\| import(\"http2\").Http2ServerRequest, res: import(\"http\").ServerResponse, next: (e?: any) =&gt; void) =&gt; Promise&lt;void&gt;; notFound: (req: import(\"http\").IncomingMessage \\| import(\"http2\").Http2ServerRequest, res: import(\"http\").ServerResponse, next: (e: any) =&gt; void) =&gt; Promise&lt;void&gt;; handle: (req: any, res: any) =&gt; void; }",
"editUrl": "https://github.com/QwikDev/qwik/tree/main/packages/qwik-router/src/middleware/aws-lambda/index.ts",
"mdFile": "router.createqwikrouter.md"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@ export declare function createQwikRouter(opts: AwsOpt): {
fixPath: (pathT: string) => string;
router: (
req: import("http").IncomingMessage | import("http2").Http2ServerRequest,
res: import("http").ServerResponse<import("http").IncomingMessage>,
res: import("http").ServerResponse,
next: import("@qwik.dev/router/middleware/node").NodeRequestNextFunction,
) => Promise<void>;
staticFile: (
req: import("http").IncomingMessage | import("http2").Http2ServerRequest,
res: import("http").ServerResponse<import("http").IncomingMessage>,
res: import("http").ServerResponse,
next: (e?: any) => void,
) => Promise<void>;
notFound: (
req: import("http").IncomingMessage | import("http2").Http2ServerRequest,
res: import("http").ServerResponse<import("http").IncomingMessage>,
res: import("http").ServerResponse,
next: (e: any) => void,
) => Promise<void>;
handle: (req: any, res: any) => void;
Expand Down Expand Up @@ -67,7 +67,7 @@ AwsOpt
</tbody></table>
**Returns:**

{ fixPath: (pathT: string) =&gt; string; router: (req: import("http").IncomingMessage \| import("http2").Http2ServerRequest, res: import("http").ServerResponse&lt;import("http").IncomingMessage&gt;, next: import("@qwik.dev/router/middleware/node").NodeRequestNextFunction) =&gt; Promise&lt;void&gt;; staticFile: (req: import("http").IncomingMessage \| import("http2").Http2ServerRequest, res: import("http").ServerResponse&lt;import("http").IncomingMessage&gt;, next: (e?: any) =&gt; void) =&gt; Promise&lt;void&gt;; notFound: (req: import("http").IncomingMessage \| import("http2").Http2ServerRequest, res: import("http").ServerResponse&lt;import("http").IncomingMessage&gt;, next: (e: any) =&gt; void) =&gt; Promise&lt;void&gt;; handle: (req: any, res: any) =&gt; void; }
{ fixPath: (pathT: string) =&gt; string; router: (req: import("http").IncomingMessage \| import("http2").Http2ServerRequest, res: import("http").ServerResponse, next: import("@qwik.dev/router/middleware/node").NodeRequestNextFunction) =&gt; Promise&lt;void&gt;; staticFile: (req: import("http").IncomingMessage \| import("http2").Http2ServerRequest, res: import("http").ServerResponse, next: (e?: any) =&gt; void) =&gt; Promise&lt;void&gt;; notFound: (req: import("http").IncomingMessage \| import("http2").Http2ServerRequest, res: import("http").ServerResponse, next: (e: any) =&gt; void) =&gt; Promise&lt;void&gt;; handle: (req: any, res: any) =&gt; void; }

[Edit this section](https://github.com/QwikDev/qwik/tree/main/packages/qwik-router/src/middleware/aws-lambda/index.ts)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
}
],
"kind": "Function",
"content": "```typescript\nexport declare function createQwikRouter(opts: QwikRouterCloudflarePagesOptions): (request: PlatformCloudflarePages['request'], env: PlatformCloudflarePages['env'] & {\n ASSETS: {\n fetch: (req: Request) => Response;\n };\n}, ctx: PlatformCloudflarePages['ctx']) => Promise<Response>;\n```\n\n\n<table><thead><tr><th>\n\nParameter\n\n\n</th><th>\n\nType\n\n\n</th><th>\n\nDescription\n\n\n</th></tr></thead>\n<tbody><tr><td>\n\nopts\n\n\n</td><td>\n\n[QwikRouterCloudflarePagesOptions](#qwikroutercloudflarepagesoptions)\n\n\n</td><td>\n\n\n</td></tr>\n</tbody></table>\n**Returns:**\n\n(request: [PlatformCloudflarePages](#platformcloudflarepages)<!-- -->\\['request'\\], env: [PlatformCloudflarePages](#platformcloudflarepages)<!-- -->\\['env'\\] &amp; { ASSETS: { fetch: (req: Request) =&gt; Response; }; }, ctx: [PlatformCloudflarePages](#platformcloudflarepages)<!-- -->\\['ctx'\\]) =&gt; Promise&lt;Response&gt;",
"content": "```typescript\nexport declare function createQwikRouter(opts: QwikRouterCloudflarePagesOptions): (request: PlatformCloudflarePages[\"request\"], env: PlatformCloudflarePages[\"env\"] & {\n ASSETS: {\n fetch: (req: Request) => Response;\n };\n}, ctx: PlatformCloudflarePages[\"ctx\"]) => Promise<Response>;\n```\n\n\n<table><thead><tr><th>\n\nParameter\n\n\n</th><th>\n\nType\n\n\n</th><th>\n\nDescription\n\n\n</th></tr></thead>\n<tbody><tr><td>\n\nopts\n\n\n</td><td>\n\n[QwikRouterCloudflarePagesOptions](#qwikroutercloudflarepagesoptions)\n\n\n</td><td>\n\n\n</td></tr>\n</tbody></table>\n**Returns:**\n\n(request: [PlatformCloudflarePages](#platformcloudflarepages)<!-- -->\\[\"request\"\\], env: [PlatformCloudflarePages](#platformcloudflarepages)<!-- -->\\[\"env\"\\] &amp; { ASSETS: { fetch: (req: Request) =&gt; Response; }; }, ctx: [PlatformCloudflarePages](#platformcloudflarepages)<!-- -->\\[\"ctx\"\\]) =&gt; Promise&lt;Response&gt;",
"editUrl": "https://github.com/QwikDev/qwik/tree/main/packages/qwik-router/src/middleware/cloudflare-pages/index.ts",
"mdFile": "router.createqwikrouter.md"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ opts
</tbody></table>
**Returns:**

(request: [PlatformCloudflarePages](#platformcloudflarepages)['request'], env: [PlatformCloudflarePages](#platformcloudflarepages)['env'] &amp; { ASSETS: { fetch: (req: Request) =&gt; Response; }; }, ctx: [PlatformCloudflarePages](#platformcloudflarepages)['ctx']) =&gt; Promise&lt;Response&gt;
(request: [PlatformCloudflarePages](#platformcloudflarepages)["request"], env: [PlatformCloudflarePages](#platformcloudflarepages)["env"] &amp; { ASSETS: { fetch: (req: Request) =&gt; Response; }; }, ctx: [PlatformCloudflarePages](#platformcloudflarepages)["ctx"]) =&gt; Promise&lt;Response&gt;

[Edit this section](https://github.com/QwikDev/qwik/tree/main/packages/qwik-router/src/middleware/cloudflare-pages/index.ts)

Expand Down
Loading