Funny Monkey Coding (FMC) Time#131
Merged
Merged
Conversation
ActuallyTaylor
requested changes
Feb 28, 2026
ActuallyTaylor
left a comment
ActuallyTaylor
left a comment
Member
There was a problem hiding this comment.
I have quite a few comments, my main note is that the PR needs to use more EVT-Core abstractions. There is a re-implementation of GPIO handling, which is already covered by our GPIO class. If it is not completely covered, the GPIO class should be subclassed and adapted.
DannyCato
reviewed
Mar 1, 2026
DannyCato
reviewed
Mar 1, 2026
DannyCato
reviewed
Mar 1, 2026
DannyCato
reviewed
Mar 1, 2026
DannyCato
reviewed
Mar 1, 2026
DannyCato
reviewed
Mar 1, 2026
DannyCato
reviewed
Mar 1, 2026
…to use EVT-core's gpio abstraction
… the base class and finally figured out how GPIO works
…into feature/ChongOscar/fmc-support # Conflicts: # include/core/io/FMC.hpp # include/core/io/platform/f4xx/FMCf4xx.hpp # src/core/io/platform/f4xx/FMCf4xx.cpp
…into feature/ChongOscar/fmc-support # Conflicts: # include/core/io/FMC.hpp # include/core/io/platform/f4xx/FMCf4xx.hpp # src/core/io/FMC.cpp # src/core/io/platform/f4xx/FMCf4xx.cpp
…of a struct, also some changes based on comments
…VT-core into feature/ChongOscar/fmc-support
Contributor
|
I'm merging this into the HUDL project's evt-core now to do debugging and revamp it with the rest of the system |
DannyCato
reviewed
May 16, 2026
aclowmclaughlin
requested changes
May 18, 2026
aclowmclaughlin
left a comment
aclowmclaughlin
left a comment
Contributor
There was a problem hiding this comment.
Just some really minor commenting things. Once they are resolved, this looks good to go.
…Calculation worked
aclowmclaughlin
approved these changes
May 29, 2026
aclowmclaughlin
left a comment
aclowmclaughlin
left a comment
Contributor
There was a problem hiding this comment.
Looks awesome. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FMC support
Added support for configuring and reading SDRAM through a Flexible Memory Controller (FMC)
Change list:
FMC: is an abstract class containing only the base address for future chip supportFMCf4xx: defines a FMC implementation for F4 boards