FWT-150 Look at my Very Stable code S#7
Merged
Conversation
DiegoLHendrix
commented
Feb 17, 2025
DiegoLHendrix
commented
Contributor
- Created a state machine that would go through the initialization, soft start, and power up state of the Vicor chip.
- Implemented power switch current, temperature, and fault status sensing.
- Added the CANopen dictionary to send and receive messages from the VCU.
- Created a union struct that would hold the value of which board to turn on.
- Made an enum class for power switch error status.
DiegoLHendrix
changed the title
Ethan-Caracoglia
left a comment
Ethan-Caracoglia
left a comment
There was a problem hiding this comment.
Looks good for the most part and it compiled when I built it. How can I test this to prove that this actually works?
…EVT/LVSS into feature/diegolhendrix/state-machine
…d IDLE state to RUNNING, and UART pins are no longer swapped
…AdcCount member variables
… a fault occurs, updated EVT-core branch used
…nstead of turning off the entire switch
aclowmclaughlin
requested changes
Apr 11, 2026
aclowmclaughlin
left a comment
aclowmclaughlin
left a comment
There was a problem hiding this comment.
Looking good. I have alot of changes, all basically just format/code style stuff.
aclowmclaughlin
approved these changes
Apr 21, 2026
tmb5932
requested changes
Apr 21, 2026
tmb5932
left a comment
tmb5932
left a comment
There was a problem hiding this comment.
ok i only looked at the can dictionary for now... i might possibly get around to the rest of it...
mjh9585
requested changes
Apr 21, 2026
mjh9585
left a comment
mjh9585
left a comment
There was a problem hiding this comment.
Definitely still a few problems but should be pretty straight forward to fix. I didn't focus too much on the logic so please, please, please test your code before merging.
tmb5932
approved these changes
Apr 23, 2026
tmb5932
left a comment
tmb5932
left a comment
There was a problem hiding this comment.
ill approve it, CAN dictionary looks good now, but i want explanation of TPDO_NODE_ID variable.
mjh9585
approved these changes
Apr 26, 2026
mjh9585
left a comment
mjh9585
left a comment
There was a problem hiding this comment.
Looks good to me as long as it has been tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.