Exposure techmix resizes to div #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to techmix-resizing
MonikaFu
changed the title
jdhoffa
requested changes
Nov 14, 2024
Comment on lines
+324
to
326
| div.d3chart svg .Steel[class*='Electric Arc Furnace'] { | ||
| fill: #dbb1bb; | ||
| } |
Member
There was a problem hiding this comment.
NB (and not so related to this PR):
We should probably add logging in case the technology types input to the dashboard are not considered in plot_styles.css. I don't have a better way of doing this in mind, but can imagine that it might lead to some odd bugs in case data isn't as expected, and at the very least we should make it easy for ourselves to debug
Member
There was a problem hiding this comment.
Can probably just make that comment into a new issue.
jdhoffa
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: