Skip to content

Exposure techmix resizes to div #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 14, 2024
Merged

Exposure techmix resizes to div #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
694929c
Update tech exposure for dashboard
MonikaFu Nov 13, 2024
af6eb2d
Sort based on sector exposure
MonikaFu Nov 13, 2024
87296f1
Merge branch 'main' of github.com:RMI-PACTA/pacta-dashboard-svelte in…
MonikaFu Nov 13, 2024
f09ed38
Update test data to align accross plots
MonikaFu Nov 13, 2024
233eb72
Fix scales
MonikaFu Nov 13, 2024
e5a3842
Fix steel techs
MonikaFu Nov 13, 2024
8457a09
Add benchmark foornote
MonikaFu Nov 13, 2024
44a4f5b
Style
MonikaFu Nov 14, 2024
590bda0
Change comment
MonikaFu Nov 14, 2024
5685710
Remove comment
MonikaFu Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/css/plot_styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ div.d3chart.WaffleChart {
}

div.d3chart .axis {
font-size: 1.6em;
font-size: 0.9em;
}

/* axis color */
Expand Down Expand Up @@ -321,20 +321,16 @@ div.d3chart svg .Cement[class*='Integrated facility'] {
fill: #c1b358;
}

div.d3chart svg .Steel[class*='Ac-Electric Arc Furnace'] {
fill: #a63d57;
div.d3chart svg .Steel[class*='Electric Arc Furnace'] {
fill: #dbb1bb;
}
Comment on lines +324 to 326
Copy link
Member

@jdhoffa jdhoffa Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB (and not so related to this PR):
We should probably add logging in case the technology types input to the dashboard are not considered in plot_styles.css. I don't have a better way of doing this in mind, but can imagine that it might lead to some odd bugs in case data isn't as expected, and at the very least we should make it easy for ourselves to debug

Copy link
Member

@jdhoffa jdhoffa Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably just make that comment into a new issue.

Copy link
Contributor Author

@MonikaFu MonikaFu Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an issue


div.d3chart svg .Steel[class*='Bof Shop'] {
div.d3chart svg .Steel[class*='Open Hearth Furnace'] {
fill: #c98a9a;
}

div.d3chart svg .Steel[class*='Dc-Electric Arc Furnace'] {
fill: #b76378;
}

div.d3chart svg .Steel[class*='Open Hearth Meltshop'] {
fill: #dbb1bb;
div.d3chart svg .Steel[class*='Basic Oxygen Furnace'] {
fill: #a63d57;
}

div.d3chart svg .Shipping[class*='A Grade'] {
Expand Down
Loading
Loading