Skip to content

Add WEO 2024 scenario data preparation into package #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Add WEO 2024 scenario data preparation into package #81

wants to merge 20 commits into from

Conversation

@Antoine-Lalechere
Copy link
Contributor

@Antoine-Lalechere Antoine-Lalechere commented Sep 2, 2025 •
edited by cjyetman
Loading

cjyetman and others added 2 commits March 12, 2025 12:46
@cjyetman
just the beginning
f251e94
@Antoine-Lalechere @jacobvjk
wip-FEAT: added Automotive to WEO2024 (#76)
a3dfd58 
* FEAT: added Automotive to WEO2024

* add weo2024 and Electric Hybrid in dictionnary

* changes after QA

* add namespace

* prepare weo 2024 geography

* adress comments + adress qa issue

* prepare weo 2024 technology bridge

* add weo 2024 ECB scenario document

* remove useless input parameter

* change location of files

* update namespace

* change function name

* add binding

* change namespace

* add data type

* remove change

* load geography_bridge and technology_bridge

* add weo in geography+technology bridge

* add namespace

* remove ecb in preprare_weo_2024_scenario

* update documentation

* remove steel and cement data

* answer comment

* correct order of args in function description

---------

Co-authored-by: jacobvjk <[email protected]>
@codecov
Copy link

codecov bot commented Sep 2, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0.43764% with 455 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.75%. Comparing base (123d3e7) to head (3e1b1b1).

Files with missing lines Patch % Lines
R/prepare_weo_2024_hybrid_in_ev_scenario.R 0.00% 455 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   16.75%   13.75%   -3.00%     
==========================================
  Files          13       14       +1     
  Lines        2059     2515     +456     
==========================================
+ Hits          345      346       +1     
- Misses       1714     2169     +455

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cjyetman
Copy link
Member

cjyetman commented Sep 2, 2025

@Antoine-Lalechere I opened #82 to add tests to this PR, so if you approve that and merge it the test will show up in here

Also, the R CMD check Notes that need to be fixed seem to be mostly variable names mentioned in dplyr functions that need to be quoted

@cjyetman
Copy link
Member

cjyetman commented Sep 3, 2025

@Antoine-Lalechere I force merged the tests because they shouldn't hurt anything you're doing. I also updated the branch so it's up to date with main, which also is just an empty commit. But, make sure you pull the latest changes before you make any changes and push them, otherwise your local repo will be out of sync.

cjyetman
cjyetman reviewed Sep 3, 2025
View reviewed changes
cjyetman
cjyetman reviewed Sep 3, 2025
View reviewed changes
@cjyetman
Copy link
Member

cjyetman commented Sep 3, 2025

@Antoine-Lalechere you're getting close... just a few config_name and is_blank variable names need a similar treatment

@Antoine-Lalechere
Copy link
Contributor Author

Antoine-Lalechere commented Sep 3, 2025

should be good now, pending this ultimate change here: RMI-PACTA/workflow.scenario.preparation#69

cjyetman
cjyetman reviewed Sep 3, 2025
View reviewed changes
@cjyetman cjyetman mentioned this pull request Sep 5, 2025
Merged
@cjyetman
Copy link
Member

cjyetman commented Sep 5, 2025

I think we also have to add something here and then regenerate the data from raw data using data-raw/prepare_raw_data.R

https://github.com/RMI-PACTA/pacta.scenario.data.preparation/blob/main/data-raw/scenario_source_pacta_geography_bridge.csv

possibly just one line WEO2024,Global,Global, but it's dependent on what regional names/indicators WEO2024 uses

cjyetman and others added 6 commits September 9, 2025 15:54
@cjyetman
update WEO2024 technology bridge (#84)
5c57c32
@cjyetman
remove the config_name argument (#83)
8a4b84f 
* remove the `config_name` argument

* Update year filter for APS and NZE scenarios
@cjyetman
alphabetize and update scenario source to pacta geography bridge (#85)
8ace237 
* alphabetize and update scenario source to pacta geography bridge

* update scenario_regions

* update sysdata
@cjyetman
remove unused scenario (#87)
dd5e025 
no Sustainable Development Scenario scenario is found in original WEO 2024 data we use here
@cjyetman
remove redundant data transformation (#86)
6d8479c 
this is redundant because the `year` values are already imported as doubles, and since this transformation is not done (or needed) anywhere else, it's a bit confusing to have it here
@cjyetman
re-document
04ba309
@cjyetman
Copy link
Member

cjyetman commented Sep 9, 2025

didn't realize technologies were being changed inside the weo_2024_extract_power() function, so I'll need to add back some technologies that were just removed from weo_2024_technology_bridge.csv before this merges

@cjyetman cjyetman self-requested a review September 10, 2025 10:09
cjyetman
cjyetman reviewed Sep 10, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyetman cjyetman cjyetman approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Antoine-Lalechere @cjyetman