Skip to content

Conversation

@Antoine-Lalechere
Copy link
Contributor

@Antoine-Lalechere Antoine-Lalechere commented Aug 11, 2025

This PR aims to add WEO2024 into scenario files.

Adding WEO2024 raised a methodology concerns in the automotive sector as we had two charts provided the same information but with different granularity. It provides us 2 options:

  • keep old classification fr Automotive (ICE, Electric and Hybrid in 3 categories). This would remove NZE pathways
    • group hybrid in electric vehicles. This would keep NZE pathway

After discussion with a stakeholder, it has been decided to go with the second option, hence the "_hybrid_in_ev" in all the filenames

@github-actions
Copy link

github-actions bot commented Aug 11, 2025

Docker build status

commit_time git_sha image
2025-09-02T16:14:56Z 1c8dce5 ghcr.io/rmi-pacta/workflow.scenario.preparation:pr-65

@Antoine-Lalechere Antoine-Lalechere marked this pull request as ready for review August 11, 2025 13:21
@AlexAxthelm
Copy link
Contributor

@Antoine-Lalechere @cjyetman I broke the "Run workflow" actions when I archived everything on Azure for PACTA. Sorry. You've been handling the process locally?

Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one request to implement a safer way of calling functions, but good otherwise

@jacobvjk jacobvjk self-requested a review September 2, 2025 14:21
jacobvjk
jacobvjk previously approved these changes Sep 2, 2025
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cjyetman
cjyetman previously approved these changes Sep 2, 2025
Copy link
Member

@cjyetman cjyetman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor variable name changes suggested for consistency, otherwise LGTM 👍🏻

@Antoine-Lalechere Antoine-Lalechere dismissed stale reviews from cjyetman and jacobvjk via 59eef12 September 2, 2025 16:08
@cjyetman
Copy link
Member

cjyetman commented Sep 2, 2025

note: if the Azure Docker builder was working, we would probably want to add 2024Q4 here also (but probably doesn't matter at this point):

matrix:
config_active:
- "2022Q4"
- "2023Q4"

Copy link
Member

@cjyetman cjyetman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that the PR that this depends on:

did not actually merge to main, it merged to a branch weo_2024 so it's not really merged/available in the traditional sense

@Antoine-Lalechere Antoine-Lalechere merged commit cd83876 into main Sep 3, 2025
5 of 7 checks passed
@Antoine-Lalechere Antoine-Lalechere deleted the weo_2024_antoine_v2 branch September 3, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants