-
Notifications
You must be signed in to change notification settings - Fork 0
Weo 2024 antoine v2 #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Docker build status
|
|
@Antoine-Lalechere @cjyetman I broke the "Run workflow" actions when I archived everything on Azure for PACTA. Sorry. You've been handling the process locally? |
jacobvjk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one request to implement a safer way of calling functions, but good otherwise
named argument calls
jacobvjk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cjyetman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor variable name changes suggested for consistency, otherwise LGTM 👍🏻
Co-authored-by: CJ Yetman <[email protected]>
59eef12
Co-authored-by: CJ Yetman <[email protected]>
Co-authored-by: CJ Yetman <[email protected]>
|
note: if the Azure Docker builder was working, we would probably want to add workflow.scenario.preparation/.github/workflows/run-scenario-preparation.yml Lines 28 to 31 in d453754
|
cjyetman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that the PR that this depends on:
did not actually merge to main, it merged to a branch weo_2024 so it's not really merged/available in the traditional sense
This PR aims to add WEO2024 into scenario files.
Adding WEO2024 raised a methodology concerns in the automotive sector as we had two charts provided the same information but with different granularity. It provides us 2 options:
After discussion with a stakeholder, it has been decided to go with the second option, hence the "_hybrid_in_ev" in all the filenames