BUMP 4.0.4#679
Merged
Merged
Conversation
…r port handling in port_handler.c
Fix build issues in C and add CMake support.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Dynamixel SDK to version 4.0.4 across all supported languages and introduces a unified CMake build system for the C and C++ libraries, along with global port tracking variables in the C port handler. Feedback focuses on enhancing the CMake configuration by allowing for static library builds, aligning the SOVERSION with the project's major version, and improving package relocatability by avoiding hardcoded installation paths. Further suggestions include using unique prefixes for example targets to avoid naming collisions and adopting safer file-specific removal practices during uninstallation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#677
This change does not introduce any modifications to the ROS package.