Add tests for rocprofiler-compute#2300
Conversation
|
This has enough reviewers other than me. I've already given some input. |
|
There is currently an issue with I could exclude this test before merging if desired, otherwise it will be failing until the following PR gets merged and TheRock submodule gets updated to include the fix: |
|
Fix for @geomin12 @jayhawk-commits @ScottTodd we'd like to get this merged ASAP so we can disable PSDB runs for rocprofiler-compute which are blocking development time. Please let me know if there are any additional changes that should be made on this PR. |
geomin12
left a comment
There was a problem hiding this comment.
looks good overall, few housekeeping comments
… to array, add build test flag
rahulc-gh
left a comment
There was a problem hiding this comment.
If required tests are passing, looks good to me
geomin12
left a comment
There was a problem hiding this comment.
thanks for comments! i know there are some housekeeping things, but we can address in a later PR
lgtm assuming it passes in CI
|
CI is passing, the only failing test is I will merge this for now but expect this one test to fail until the next Thanks again! |
This reverts commit 5f60db7.
## Motivation <!-- Explain the purpose of this PR and the goals it aims to achieve. --> gfx103X builds appear to be failing since #2300 got merged. This should address these build errors and unblock gfx103X releases. ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> - rocprofiler-compute does not support gfx103X architectures, so we added the project to the `EXCLUDE_TARGET_PROJECTS` list for the gfx103X family in `therock_amdgpu_targets.cmake` - It appears that `EXCLUDE_TARGET_PROJECTS` entries for rocprofiler-compute gfx1031, gfx1033, and gfx1034 were missing - This was due to #1629 being merged two weeks ago, and the changes related to `therock_amdgpu_targets.cmake` in the #2300 PR happening before this new inclusion - Failures were not found before merging due to PR not running gfx103X builds ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> Ensure that gfx103X builds are able to pass without any errors from rocprofiler-compute ## Test Result <!-- Briefly summarize test outcomes. --> - Ran a manual gfx103X workflow with these changes: https://github.com/ROCm/TheRock/actions/runs/22497338111/job/65175257319 ## Submission Checklist - [X] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
Motivation
Add test coverage for
rocprofiler-computecomponentTechnical Details
CMakeLists.txtforrocprofiler-computeto build and install testsartifact-rocprofiler-sdk.tomlto include necessary test requirements for rocprofiler-compute under the test artifact for sdkfetch_test_configurations.pyto includerocprofiler-compute, addedrequirements-filesparameter to pass along totest_component.ymlto install pip reqs (compute requires additional pip requirements to run)test_component.ymlto run a setup step before the test step that will runinstall_requirements.pyto install additionalrequirements.txtfiles as needed for testscmake/therock_amdgpu_targets.cmaketo exclude rocprofiler-compute for unsupported devicestest_rocprofiler_compute.pyto run ctest on compute testsTest Plan
JIRA ID
ROCM-324
Test Result
test_profile_pc_samplingtest has been excluded from running due to its constant failing right now due to a rocr issue (see Jira mentioned in comment intest_rocprofiler_compute.py), this can be added back once it is confirmed to be fixedSubmission Checklist