Add tests for rocprofiler-compute #2300
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jbonnell-amd marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| import logging | ||
| import os | ||
| import shlex | ||
| import subprocess | ||
| from pathlib import Path | ||
|
|
||
| # Resolve paths | ||
| THEROCK_BIN_DIR = os.getenv("THEROCK_BIN_DIR") | ||
| OUTPUT_ARTIFACTS_DIR = os.getenv("OUTPUT_ARTIFACTS_DIR") | ||
| SCRIPT_DIR = Path(__file__).resolve().parent | ||
| THEROCK_DIR = SCRIPT_DIR.parent.parent.parent | ||
|
jbonnell-amd marked this conversation as resolved.
|
||
|
|
||
| THEROCK_BIN_PATH = Path(THEROCK_BIN_DIR).resolve() | ||
| THEROCK_PATH = THEROCK_BIN_PATH.parent | ||
| THEROCK_LIB_PATH = str(THEROCK_PATH / "lib") | ||
| ROCPROFILER_COMPUTE_DIRECTORY = THEROCK_PATH / "libexec" / "rocprofiler-compute" | ||
|
|
||
| # Set up ROCM_PATH | ||
| environ_vars = os.environ.copy() | ||
| environ_vars["ROCM_PATH"] = str(THEROCK_PATH) | ||
|
|
||
| # Set up PATH | ||
| old_path = os.getenv("PATH", "") | ||
|
jbonnell-amd marked this conversation as resolved.
|
||
| rocm_bin = str(THEROCK_BIN_PATH) | ||
| if old_path: | ||
| environ_vars["PATH"] = f"{rocm_bin}:{old_path}" | ||
| else: | ||
| environ_vars["PATH"] = rocm_bin | ||
|
|
||
| # Set up LD_LIBRARY_PATH | ||
| old_ld_lib_path = os.getenv("LD_LIBRARY_PATH", "") | ||
|
jbonnell-amd marked this conversation as resolved.
|
||
| sysdeps_path = f"{THEROCK_LIB_PATH}/rocm_sysdeps/lib" | ||
| if old_ld_lib_path: | ||
| environ_vars["LD_LIBRARY_PATH"] = ( | ||
| f"{THEROCK_LIB_PATH}:{sysdeps_path}:{old_ld_lib_path}" | ||
| ) | ||
| else: | ||
| environ_vars["LD_LIBRARY_PATH"] = f"{THEROCK_LIB_PATH}:{sysdeps_path}" | ||
|
|
||
| # Set up excluded tests (include Jiras) | ||
| # AIPROFSDK-36: rocr issue causing test to fail | ||
| EXCLUDED_TESTS = [ | ||
| "test_profile_pc_sampling", | ||
| ] | ||
|
|
||
| # Sharding | ||
| shard_index = int(os.getenv("SHARD_INDEX", "1")) - 1 | ||
| total_shards = int(os.getenv("TOTAL_SHARDS", "1")) | ||
|
|
||
| # Smoke Tests Setup | ||
| SMOKE_TESTS = [ | ||
|
Contributor
Author
There was a problem hiding this comment. @vedithal-amd any feedback on this selection for smoke tests? We want a subset of tests to run in the regular CI with a shorter runtime (this current set takes about 10 minutes, don't want much longer than that), and the full suite will run on nightly runs. I just chose the non-profiling ones to run as smoke for now due to their shorter runtime, but open to switching these to a wider range if that would be preferred.
Contributor
There was a problem hiding this comment. What is the point of smoke tests, will this run on every PR? This list looks good to me, lets also add
Member
There was a problem hiding this comment.
jbonnell-amd marked this conversation as resolved.
|
||
| "test_autogen_config", | ||
| "test_utils", | ||
| "test_num_xcds_cli_output", | ||
| "test_num_xcds_spec_class", | ||
| "test_L1_cache_counters", | ||
| "test_analyze_workloads", | ||
| "test_analyze_commands", | ||
| "test_metric_validation", | ||
| "test_profile_iteration_multiplexing_1", | ||
| ] | ||
|
|
||
| # Run tests | ||
| cmd = [ | ||
| "ctest", | ||
| "--test-dir", | ||
| f"{ROCPROFILER_COMPUTE_DIRECTORY}", | ||
|
jbonnell-amd marked this conversation as resolved.
|
||
| "--output-on-failure", | ||
| "--verbose", | ||
| "--exclude-regex", | ||
| f"{"|".join(EXCLUDED_TESTS)}", | ||
| "--tests-information", | ||
| f"{shard_index},,{total_shards}", | ||
| ] | ||
|
|
||
| # If smoke tests are enabled, we run smoke tests only. | ||
| # Otherwise, we run the normal test suite | ||
| test_type = os.getenv("TEST_TYPE", "full") | ||
| if test_type == "smoke": | ||
| cmd.append("--tests-regex") | ||
| cmd.append("|".join(SMOKE_TESTS)) | ||
|
|
||
| logging.info(f"++ Exec [{THEROCK_PATH}]$ {shlex.join(cmd)}") | ||
| subprocess.run( | ||
| cmd, | ||
| cwd=THEROCK_PATH, | ||
| check=True, | ||
| env=environ_vars, | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| #!/usr/bin/env python | ||
|
|
||
| import argparse | ||
| import logging | ||
| import os | ||
| import shlex | ||
| import subprocess | ||
| from pathlib import Path | ||
| import sys | ||
|
|
||
| SCRIPT_DIR = Path(__file__).resolve().parent | ||
| THEROCK_DIR = SCRIPT_DIR.parent | ||
| THEROCK_OUTPUT_DIR = str(THEROCK_DIR / "build") | ||
|
|
||
|
|
||
| def setup_pip(): | ||
| environ_vars = os.environ.copy() | ||
|
|
||
| setup_cmd = [ | ||
| sys.executable, | ||
| "-m", | ||
| "ensurepip", | ||
| "--upgrade", | ||
| ] | ||
| logging.info(f"++ Exec [{THEROCK_DIR}]$ {shlex.join(setup_cmd)}") | ||
| subprocess.run(setup_cmd, cwd=THEROCK_DIR, check=True, env=environ_vars) | ||
|
|
||
|
|
||
| def install_requirements(input: str): | ||
| environ_vars = os.environ.copy() | ||
|
|
||
| requirements_files = input.split(",") | ||
|
|
||
| for file in requirements_files: | ||
| cmd = [ | ||
| sys.executable, | ||
| "-m", | ||
| "pip", | ||
| "install", | ||
| "-r", | ||
| f"{THEROCK_OUTPUT_DIR}/{file}", | ||
| ] | ||
| logging.info(f"++ Exec [{THEROCK_DIR}]$ {shlex.join(cmd)}") | ||
| subprocess.run(cmd, cwd=THEROCK_DIR, check=True, env=environ_vars) | ||
|
|
||
|
|
||
| def main(argv): | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument( | ||
| "--requirements-files", | ||
| type=str, | ||
| default="", | ||
| help="A comma separated list of requirements.txt files to install", | ||
| ) | ||
| args = parser.parse_args(argv) | ||
| if not args.requirements_files: | ||
| logging.info( | ||
| "No requirements file(s) found. Exiting install_requirements.py..." | ||
| ) | ||
| sys.exit(0) | ||
|
|
||
| setup_pip() | ||
| install_requirements(str(args.requirements_files)) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main(sys.argv[1:]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.