Media Libraries - rocDecode & rocJPEG tests by kiritigowda · Pull Request #3098 · ROCm/TheRock

kiritigowda · 2026-01-26T21:19:15Z

Motivation

Add media library tests for rocdecode and rocjpeg

Technical Details

Media tests for rocdecode and rocjpeg added to current test flow

Test Plan

rocdecode and rocjpeg tests added into the test workflow

Test Result

All tests should pass with rocdecode and rocjpeg

Submission Checklist

[x ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

* Submodules - Add media lib sources * Media Libs - Framework * Media - Update deps * Fix CMakeLists * Media - Build topology addition * Media - Build fix * Build - Add rocm path * Test - Add ctests * Packaging - Add media libs * Fix merge conflicts * Fix - bundled name * Cleanup * Fix - Test scripts * Fix black * Fix typo * Fix - media libs * Tests - Fix test path * Black fix * Media - add enable variables and fix tests * Test - Add artifacts for test * Artifacts for test - Install required * Media Test - Add base dev artifacts * Tests - Add Ninja to build * Test - Fix rocdecode failure * Packaging - Add python infra for media * Black -fix * Python Package - media templates * Test - Fix rocJPEG * Python Package - Fix typo * Artifacts - clean up * PyPackage - Filter media contents

AryanSalmanpour · 2026-01-26T23:40:39Z

Audit logs:
TheRock_audit_librocjpeg.txt
TheRock_audit_librocdecode.txt

CTEST results:
rocDecode CTEST results on CI
rocJPEG CTEST results on CI

marbre

Some first drive-by comments. This is a huge PR and it could have been splited into smaller ones which would be easier to review (e.g. building,tests, packaging).

kiritigowda · 2026-01-28T20:56:18Z

Audit logs:
TheRock_audit_librocjpeg.txt
TheRock_audit_librocdecode.txt

marbre

My previous comments have not been addressed, please do so before requesting another review. Furthermore, I need to say this once again, the PR is too large to review. If you want fast review feedback, split up the PR to allow reviewers to focus on the smaller logical chunks.

kiritigowda · 2026-02-04T18:45:42Z

Requires PR #3246 to pass ci

geomin12 · 2026-03-14T03:52:32Z

any updates on this? we would like to get this landed! seems the PR has been open for ~ 2 months

kiritigowda · 2026-03-18T02:14:00Z

replaced with #4025

## Motivation Add media tests to CI ## Technical Details Replacing #3098 ## Test Plan Add test rocdecode and test rocjpeg ## Test Result All tests should pass ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

kiritigowda requested review from AryanSalmanpour, jayhawk-commits and rrawther January 26, 2026 21:19

kiritigowda self-assigned this Jan 26, 2026

kiritigowda added the enhancement New feature or request label Jan 26, 2026

kiritigowda changed the title ~~Media Libraries - rocDecode & rocJPEG integration (#1)~~ Media Libraries - rocDecode & rocJPEG integration Jan 26, 2026

AryanSalmanpour requested a review from stellaraccident January 27, 2026 18:11

kiritigowda requested a review from nunnikri January 27, 2026 19:14

marbre reviewed Jan 27, 2026

View reviewed changes

rrawther approved these changes Jan 28, 2026

View reviewed changes

marbre requested changes Jan 28, 2026

View reviewed changes

Comment thread media-libs/CMakeLists.txt Outdated

Comment thread media-libs/CMakeLists.txt Outdated

Comment thread BUILD_TOPOLOGY.toml

kiritigowda and others added 3 commits January 28, 2026 12:43

Review - Fixes

11eebe9

Merge branch 'main' into kg/media-libs-for-therock

b7bc6b6

Fix - pre-commit

77e3a5a

kiritigowda requested a review from marbre January 28, 2026 20:54

Fix - Fetch source updates

5a93910

ScottTodd reviewed Jan 29, 2026

View reviewed changes

Comment thread CLAUDE.md

Comment thread .gitmodules Outdated

Merge branch 'main' into kg/media-libs-for-therock

e4fe5c4

kiritigowda requested a review from arvindcheru January 30, 2026 19:30

raramakr requested changes Jan 31, 2026

View reviewed changes

Comment thread build_tools/packaging/linux/package.json Outdated

Comment thread build_tools/packaging/linux/package.json Outdated

Comment thread build_tools/packaging/linux/package.json Outdated

raramakr previously requested changes Jan 31, 2026

View reviewed changes

Comment thread build_tools/packaging/linux/package.json Outdated

marbre requested changes Feb 3, 2026

View reviewed changes

Comment thread build_tools/github_actions/fetch_test_configurations.py Outdated

Comment thread build_tools/github_actions/fetch_test_configurations.py Outdated

Comment thread media-libs/CMakeLists.txt Outdated

kiritigowda and others added 4 commits February 4, 2026 10:47

Media - Submodules and reviewer comments fix

4cd6c52

Merge branch 'main' into kg/media-libs-for-therock

29a34d5

Merge branch 'main' into kg/media-libs-for-therock

d2f3c1c

Packaging - Cleanup deps

16e7031

kiritigowda marked this pull request as ready for review February 23, 2026 18:15

kiritigowda added 6 commits February 23, 2026 10:23

Merge branch 'main' into kg/media-libs-for-therock

8d49687

Merge branch 'main' into kg/media-libs-for-therock

9d15e4a

Update install_rocm_from_artifacts.py

9dcd1b4

Update BUILD_TOPOLOGY.toml

8733de0

Update fetch_test_configurations.py - Add tests

99b11be

Merge branch 'main' into kg/media-libs-for-therock

d107593

kiritigowda mentioned this pull request Feb 25, 2026

Media Libraries - Python package #3579

Merged

1 task

kiritigowda and others added 4 commits February 26, 2026 11:02

Packaging - use pr#3579

42a2f97

Merge branch 'main' into kg/media-libs-for-therock

fff2a18

CLAUDE.md - reset

3a2578a

Merge branch 'main' into kg/media-libs-for-therock

137b299

kiritigowda changed the title ~~Media Libraries - rocDecode & rocJPEG integration~~ Media Libraries - rocDecode & rocJPEG tests Feb 26, 2026

kiritigowda and others added 4 commits February 27, 2026 12:12

Merge branch 'main' into kg/media-libs-for-therock

75e12da

Test - enhancements

6015421

Merge branch 'main' into kg/media-libs-for-therock

ed7f639

Merge branch 'main' into kg/media-libs-for-therock

9c46d7a

LakshmiKumar23 self-requested a review March 4, 2026 17:13

kiritigowda added 2 commits March 6, 2026 16:50

Merge branch 'main' into kg/media-libs-for-therock

c47d517

Merge branch 'main' into kg/media-libs-for-therock

d5901eb

kiritigowda mentioned this pull request Mar 13, 2026

[Issue]: Media CI Tests - Cleanup and optimize ROCm/rocm-systems#4070

Open

geomin12 mentioned this pull request Mar 14, 2026

Media libraries - Min build for rocm-systems ROCm/rocm-systems#3939

Merged

1 task

Merge branch 'main' into kg/media-libs-for-therock

67db21c

kiritigowda mentioned this pull request Mar 18, 2026

Media Tests - Add rocdecode & rocjpeg #4025

Merged

1 task

kiritigowda closed this Mar 18, 2026

Conversation

kiritigowda commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Uh oh!

AryanSalmanpour commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marbre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kiritigowda commented Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marbre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kiritigowda commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geomin12 commented Mar 14, 2026

Uh oh!

kiritigowda commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

kiritigowda commented Jan 26, 2026 •

edited

Loading

AryanSalmanpour commented Jan 26, 2026 •

edited

Loading

kiritigowda commented Feb 4, 2026 •

edited

Loading