add hardcoded or fixed number to fetch rocm 7.2.0#270
Open
add hardcoded or fixed number to fetch rocm 7.2.0#270
Conversation
charleshofer
requested changes
Jan 22, 2026
ci/pytest_drop_test_list.ini
Outdated
Collaborator
There was a problem hiding this comment.
Why are we deleting this in this PR? This has nothing to do with hardcoding the ROCm build number
Contributor
Author
There was a problem hiding this comment.
oops yeah I added back
psanal35
approved these changes
Jan 23, 2026
charleshofer
requested changes
Jan 26, 2026
Collaborator
charleshofer
left a comment
charleshofer
left a comment
There was a problem hiding this comment.
Now that 7.2.0 is public, we shouldn't need this PR anymore. You can probably just close it.
Contributor
|
This PR seems to be no longer needed. Should we close it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We can't use "lastsuccessful" run of the
compute-rocm-dkms-no-npi-hipclangas they tend to change the version of rocm over time. Current "lastsuccessful" points to the rocm 7.3.0. To workaround this we still need to hardcode code this, and keep on using this until the rock migration is complete.