Skip to content

add hardcoded or fixed number to fetch rocm 7.2.0 #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ruturaj4 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add hardcoded or fixed number to fetch rocm 7.2.0 #270

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7f8b99
add hardcoded or fixed number to fetch rocm 7.2.0
Ruturaj4 Jan 22, 2026
df0df4f
add init file
Ruturaj4 Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-base-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
runner-label: "linux-x86-64-1gpu-amd"
- rocm-version: "7.2.0"
rocm-build-job: "compute-rocm-dkms-no-npi-hipclang"
# rocm-build-num auto-fetched from Jenkins (latest successful build)
rocm-build-num: "16885"
runner-label: "internal"
steps:
- name: Clean up old runs
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
runner-label: '["linux-x86-64-1gpu-amd"]'
- rocm-version: "7.2.0"
rocm-build-job: "compute-rocm-dkms-no-npi-hipclang"
# rocm-build-num auto-fetched from Jenkins (latest successful build)
rocm-build-num: "16885"
runner-label: '["internal"]'
uses: ./.github/workflows/build-wheels.yml
with:
Expand All @@ -50,7 +50,7 @@ jobs:
runner-label: '["linux-x86-64-1gpu-amd"]'
- rocm-version: "7.2.0"
rocm-build-job: "compute-rocm-dkms-no-npi-hipclang"
# rocm-build-num auto-fetched from Jenkins (latest successful build)
rocm-build-num: "16885"
runner-label: '["internal"]'
uses: ./.github/workflows/build-docker.yml
with:
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
with:
rocm-version: ${{ matrix.rocm-version }}
ubuntu-version: ${{ matrix.ubuntu-version }}
rocm-build-num: ${{ matrix.rocm-build-num || '0' }}
rocm-build-num: ${{ matrix.rocm-build-num || '16885' }}
github-sha: ${{ github.sha }}
github-run-id: ${{ github.run_id }}
runner-label: ${{ matrix.runner-label }}
Expand Down
48 changes: 0 additions & 48 deletions ci/pytest_drop_test_list.ini
View file
Open in desktop
Copy link
Collaborator

@charleshofer charleshofer Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we deleting this in this PR? This has nothing to do with hardcoding the ROCm build number

Copy link
Contributor Author

@Ruturaj4 Ruturaj4 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops yeah I added back

This file was deleted.

Loading