Skip to content

ci: run lint on all platforms - #496

Closed
nightcityblade wants to merge 1 commit into
RamenDR:mainfrom
nightcityblade:fix/issue-191
Closed

ci: run lint on all platforms#496
nightcityblade wants to merge 1 commit into
RamenDR:mainfrom
nightcityblade:fix/issue-191

Conversation

@nightcityblade

Copy link
Copy Markdown

Fixes #191

Summary

  • run the Go lint job on Ubuntu, Windows, and macOS
  • configure Windows checkouts to keep LF line endings for consistent formatter results

Testing

  • actionlint .github/workflows/test.yaml
  • make pre-commit
  • go test ./...

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 751763cd-dc32-456a-96ec-cd603cf709ae

📥 Commits

Reviewing files that changed from the base of the PR and between ab0d3ea and 2832cf7.

📒 Files selected for processing (1)
  • .github/workflows/test.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/test.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Expanded lint checks to run on Ubuntu, Windows, and macOS.
    • Standardized line endings during Windows validation for more consistent results.

Walkthrough

The lint job now runs on Ubuntu 24.04, Windows, and macOS 15. Windows checkout configuration disables automatic Git line-ending conversion and enforces LF endings.

Changes

Cross-platform lint validation

Layer / File(s) Summary
Lint runner matrix and checkout settings
.github/workflows/test.yaml
The lint job uses Ubuntu, Windows, and macOS runners. Windows configures Git to preserve LF line endings.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the primary CI change: running lint on all platforms.
Description check ✅ Passed The description directly explains the platform matrix and Windows line-ending configuration.
Linked Issues check ✅ Passed The changes satisfy issue #191 by running lint on Ubuntu, Windows, and macOS.
Out of Scope Changes check ✅ Passed The workflow changes are limited to the linked issue objectives and related CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nirs nirs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nightcityblade Thanks for the PR!

Comment thread .github/workflows/test.yaml Outdated
strategy:
fail-fast: false
matrix:
runner: [ubuntu-24.04, windows-latest, macos-15]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use -latest for all. We want to lint on the latest version of all runners, and we don't want to spend time on updating the actual version.

Comment thread .github/workflows/test.yaml Outdated
if: runner.os == 'Windows'
run: |
git config --global core.autocrlf false
git config --global core.eol lf

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use https://github.com/RamenDR/ramenctl/blob/main/.gitattributes to avoid issue with windows so this should not be needed. If we have issue without his it means we need to update our .gitattributes file.

Lets start by removing this special code for windows to see if the build pass.

@nirs

nirs commented Aug 9, 2026

Copy link
Copy Markdown
Member

@nightcityblade Please rebase on main before creating a PR next time.

Signed-off-by: nightcityblade <nightcityblade@gmail.com>
@nightcityblade

Copy link
Copy Markdown
Author

Apologies — while updating the branch to address the review feedback, I recreated its history and GitHub closed this PR automatically. The corrected, rebased one-commit replacement is #497; it includes the requested -latest runners and removes the Windows-specific Git configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run lint on all platforms?

2 participants