ci: run lint on all platforms - #496
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe lint job now runs on Ubuntu 24.04, Windows, and macOS 15. Windows checkout configuration disables automatic Git line-ending conversion and enforces LF endings. ChangesCross-platform lint validation
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nirs
left a comment
There was a problem hiding this comment.
@nightcityblade Thanks for the PR!
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| runner: [ubuntu-24.04, windows-latest, macos-15] |
There was a problem hiding this comment.
Please use -latest for all. We want to lint on the latest version of all runners, and we don't want to spend time on updating the actual version.
| if: runner.os == 'Windows' | ||
| run: | | ||
| git config --global core.autocrlf false | ||
| git config --global core.eol lf |
There was a problem hiding this comment.
We use https://github.com/RamenDR/ramenctl/blob/main/.gitattributes to avoid issue with windows so this should not be needed. If we have issue without his it means we need to update our .gitattributes file.
Lets start by removing this special code for windows to see if the build pass.
|
@nightcityblade Please rebase on main before creating a PR next time. |
Signed-off-by: nightcityblade <nightcityblade@gmail.com>
2832cf7 to
dbacd76
Compare
|
Apologies — while updating the branch to address the review feedback, I recreated its history and GitHub closed this PR automatically. The corrected, rebased one-commit replacement is #497; it includes the requested |
Fixes #191
Summary
Testing
actionlint .github/workflows/test.yamlmake pre-commitgo test ./...