Updates for R-CMD-check-occasional to pass with minimal CI noise - #7832
Merged
Conversation
MichaelChirico
force-pushed
the
occasional-fix
branch
from
July 23, 2026 22:51
6c17ed0 to
8959629
Compare
MichaelChirico
force-pushed
the
occasional-fix
branch
3 times, most recently
from
July 23, 2026 23:17
dcbf1f9 to
0dec4cc
Compare
Generated via commit 150737f Download link for the artifact containing the test results: ↓ atime-results.zip
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## utf8-old-windows #7832 +/- ##
=================================================
Coverage 99.01% 99.01%
=================================================
Files 88 88
Lines 17286 17286
=================================================
Hits 17116 17116
Misses 170 170 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MichaelChirico
force-pushed
the
other-attach-order
branch
from
July 24, 2026 06:05
5dde771 to
58ce9c4
Compare
MichaelChirico
force-pushed
the
occasional-fix
branch
from
July 24, 2026 06:05
0dec4cc to
3829679
Compare
MichaelChirico
changed the base branch from
other-attach-order
to
test-err-show-diff
July 24, 2026 13:58
MichaelChirico
force-pushed
the
occasional-fix
branch
2 times, most recently
from
July 24, 2026 14:21
44d6f05 to
8917b16
Compare
MichaelChirico
force-pushed
the
test-err-show-diff
branch
2 times, most recently
from
July 24, 2026 16:48
6f23983 to
f93fce1
Compare
MichaelChirico
force-pushed
the
occasional-fix
branch
4 times, most recently
from
July 24, 2026 22:35
c6a3e01 to
ab2efd5
Compare
MichaelChirico
force-pushed
the
test-err-show-diff
branch
from
July 26, 2026 16:54
f93fce1 to
746918d
Compare
MichaelChirico
force-pushed
the
occasional-fix
branch
from
July 26, 2026 16:58
ab2efd5 to
d04e4a2
Compare
MichaelChirico
changed the base branch from
test-err-show-diff
to
fix-latvian-tests
July 26, 2026 17:04
MichaelChirico
force-pushed
the
occasional-fix
branch
from
July 26, 2026 17:55
d04e4a2 to
ef2c4b6
Compare
MichaelChirico
force-pushed
the
fix-latvian-tests
branch
2 times, most recently
from
July 26, 2026 20:46
995819c to
d56f300
Compare
MichaelChirico
force-pushed
the
occasional-fix
branch
from
July 26, 2026 20:46
ef2c4b6 to
d2945ae
Compare
MichaelChirico
force-pushed
the
fix-latvian-tests
branch
from
July 26, 2026 21:20
d56f300 to
9548bbd
Compare
MichaelChirico
force-pushed
the
occasional-fix
branch
from
July 26, 2026 21:20
d2945ae to
0e3a5a1
Compare
MichaelChirico
force-pushed
the
utf8-old-windows
branch
from
July 28, 2026 05:37
967c907 to
bc3038c
Compare
MichaelChirico
force-pushed
the
occasional-fix
branch
from
July 28, 2026 05:37
1a6f200 to
8ab5c0f
Compare
MichaelChirico
force-pushed
the
utf8-old-windows
branch
from
July 28, 2026 15:02
bc3038c to
746082f
Compare
MichaelChirico
force-pushed
the
occasional-fix
branch
2 times, most recently
from
July 28, 2026 16:17
1341050 to
03cd5af
Compare
MichaelChirico
force-pushed
the
occasional-fix
branch
from
July 28, 2026 20:15
03cd5af to
db993e7
Compare
MichaelChirico
force-pushed
the
utf8-old-windows
branch
from
July 28, 2026 20:15
f3bde87 to
4e1c8ba
Compare
MichaelChirico
force-pushed
the
occasional-fix
branch
from
July 28, 2026 20:25
db993e7 to
9bfb8aa
Compare
MichaelChirico
force-pushed
the
utf8-old-windows
branch
2 times, most recently
from
July 28, 2026 20:26
40bd8d6 to
a0a8500
Compare
MichaelChirico
force-pushed
the
occasional-fix
branch
from
July 28, 2026 20:26
9bfb8aa to
049b587
Compare
FALSE || integer() gives NA; grep() was never right to use. I'm not sure if res could ever have length()>1, but doesn't hurt
- fix brew untap handling - suppress whitespace compiler warnings - workaround liminal repos' warnings about lacking binary packages etc. This was co-written with Gemini.
MichaelChirico
force-pushed
the
occasional-fix
branch
from
July 28, 2026 20:46
049b587 to
ed9b83d
Compare
MichaelChirico
force-pushed
the
utf8-old-windows
branch
from
July 28, 2026 20:46
a0a8500 to
8fe3782
Compare
Member
Author
|
Merging: this only touches the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The work here represents diagnosis+fix mainly by Gemini, with some back-and-forth + my input. I didn't quite keep all the commits from Gemini strictly pristine, but anything where there's any Gemini authorship has the commit message prefixed with
Gemini:(with possible clean-up edits by me). The most crucial logjam was broken w.r.t._R_CHECK_DEPENDS_ONLY_, as described by Gemini below:Setting
_R_CHECK_DEPENDS_ONLY_: falsein .github/workflows/R-CMD-check-occasional.yaml overrides a default behavior of--as-craninR CMD checkthat hides optional packages from the test suite:1. Default Behavior of
--as-craninR CMD checkUnder
--as-cran, R automatically enables_R_CHECK_DEPENDS_ONLY_=true:data.table/.github/workflows/R-CMD-check-occasional.yaml
Line 117 in fae95de
When active, R creates a restricted, temporary library (
.libPaths()) during the check containing only the packages explicitly listed in DESCRIPTION (Depends,Imports,Suggests, andEnhances), plus base/recommended R packages. Any other packages installed on the system are hidden from the search path during test execution.2. Why This Broke
other.Rrawin CIIn step 82 of R-CMD-check-occasional.yaml, the workflow installs "fully optional packages" (
other_pkgssuch ascaret,dplyr,ggplot2,sf,vctrs, etc.) so they can be tested for interoperability in inst/tests/other.Rraw. These optional packages are intentionally not listed indata.table'sDESCRIPTIONfile.Because they are omitted from
DESCRIPTION,--as-cranstripped them from.libPaths()during check execution. Even though the step successfully installed all 19 optional packages and setTEST_DATA_TABLE_WITH_OTHER_PACKAGES=TRUE, insideR CMD check,other.Rrawcould not find them and aborted across all CI runners with:3. Effect of the Change
By explicitly setting
_R_CHECK_DEPENDS_ONLY_: false, we preventR CMD checkfrom isolating the check library strictly toDESCRIPTIONdependencies. This allowsother.Rrawto see and attach the optional packages installed in the runner library during the check.