Fixes lint warnings

[kgaikwad]

Refer:

1. ros-frontend/src/Components/InstanceTypes/SuggestedInstanceTypesTable.js 42:8 warning React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array - react-hooks/exhaustive-deps
2. ros-frontend/src/Routes/RosSuggestedInstanceTypes/RosSuggestedInstanceTypes.js 28:8 warning React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array - react-hooks/exhaustive-deps 65:8 warning React Hook useEffect has missing dependencies: 'hideGlobalFilter' and 'updateDocumentTitle'. Either include them or remove the dependency array - react-hooks/exhaustive-deps

PR Title 💥

Please title this PR with a summary of the change, along with the JIRA card number.

Suggested formats:

1. Fixes/Refs #RHIROS-XXX - Title
2. RHIROS-XXX Title

Feel free to remove this section from PR description once done.

Why do we need this change? 💭

Please include the context of this change here.

Documentation requires update? 📝

• Yes
• No

Security Checklist 🔒

Upon raising this PR please go through RedHatInsights/secure-coding-checklist

💂‍♂️ Checklist 🎯

• Bugfix
• New Feature
• Refactor
• Unittests Added
• DRY code
• Dependency Added

Additional 📣

Feel free to add any other relevant details such as links, notes, screenshots, here.

Summary by Sourcery

Ensure exhaustive-deps lint compliance by adding missing dependencies to useEffect hooks in RosSuggestedInstanceTypes and SuggestedInstanceTypesTable

Enhancements:

• Include dispatch in the useEffect dependency array for loading configuration and suggested instance types
• Include updateDocumentTitle and hideGlobalFilter in the useEffect dependency array for document title update and global filter hiding

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR resolves react-hooks/exhaustive-deps lint warnings by explicitly adding missing dependencies to several useEffect hooks across the SuggestedInstanceTypesTable and RosSuggestedInstanceTypes components.

Class diagram for updated useEffect dependencies in SuggestedInstanceTypesTable and RosSuggestedInstanceTypes

classDiagram
class SuggestedInstanceTypesTable {
  +dispatch
  +page
  +perPage
  +activeSortDirection
  +activeSortColumnKey
  +instanceTypeName
  useEffect(loadSuggestedInstanceTypes) // dependencies: dispatch, page, perPage, activeSortDirection, activeSortColumnKey, instanceTypeName
}

class RosSuggestedInstanceTypes {
  +dispatch
  +updateDocumentTitle
  +hideGlobalFilter
  useEffect(loadIsConfiguredInfo) // dependencies: dispatch
  useEffect(updateDocumentTitle, hideGlobalFilter) // dependencies: updateDocumentTitle, hideGlobalFilter
}

Loading

File-Level Changes

Change	Details	Files
Added missing dispatch dependency to useEffect	Included dispatch in the dependency array of the initial configuration loader effect	src/Routes/RosSuggestedInstanceTypes/RosSuggestedInstanceTypes.js
Added missing updateDocumentTitle and hideGlobalFilter dependencies to useEffect	Included updateDocumentTitle and hideGlobalFilter in the dependency array of the title and filter effect	src/Routes/RosSuggestedInstanceTypes/RosSuggestedInstanceTypes.js
Added missing dependencies to SuggestedInstanceTypesTable effect	Added dispatch, page, perPage, activeSortDirection, activeSortColumnKey, and instanceTypeName to the dependency array	src/Components/InstanceTypes/SuggestedInstanceTypesTable.js

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Ensure that updateDocumentTitle and hideGlobalFilter are stable (e.g., memoized via useCallback) so adding them to the dependency arrays doesn’t cause unintended effect re-runs.
• Consider extracting the document title and global filter side-effects into a custom hook to DRY up the repeated useEffect logic across components.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Ensure that updateDocumentTitle and hideGlobalFilter are stable (e.g., memoized via useCallback) so adding them to the dependency arrays doesn’t cause unintended effect re-runs.
- Consider extracting the document title and global filter side-effects into a custom hook to DRY up the repeated useEffect logic across components.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}