Skip to content

[4.3] Implement vertex shading - #986

Closed
mcdubhghlas wants to merge 1 commit into
Redot-Engine:4.3from
mcdubhghlas:4.3
Closed

[4.3] Implement vertex shading#986
mcdubhghlas wants to merge 1 commit into
Redot-Engine:4.3from
mcdubhghlas:4.3

Conversation

@mcdubhghlas

Copy link
Copy Markdown
Member

(cherry picked from commit da08aa6)

This adds support in all backends, but the Compatibility renderer works the best.
Mobile and Forward+ can only support one directional light shader (the first in the tree)
While the Compatibility renderer supports any number of shadows.

Co-authored-by: Clay John <claynjohn@gmail.com>
@mcdubhghlas

Copy link
Copy Markdown
Member Author

Heads up: There is an odd bug here. It works just fine if you open a project directly, but if you don't you get a long error that ends with this:

ERROR: SceneShaderGLES3: Fragment shader compilation failed:
0(1552) : error C7102: unmatched #endif

   at: _display_error_with_code (drivers/gles3/shader_gles3.cpp:256)
ERROR: Method/function failed.
   at: _compile_specialization (drivers/gles3/shader_gles3.cpp:398)
WARNING: shader failed to compile, unable to bind shader.
     at: _version_bind_shader (./drivers/gles3/shader_gles3.h:224)

@Spartan322

Spartan322 commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

That issue needs to be fixed before a merge first.

@mcdubhghlas

Copy link
Copy Markdown
Member Author

Closing, I've not the time to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants