Preserve unreadable preferences and emit explicit nulls in status JSON - #37
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from the batch-2 hardening PR to isolate CI timing:\n\n- APP-05:
AppPreferencesStore.load()preserves a.bakof an unreadable preferences file before any overwrite.\n- AGENT-04:AgentControlStatusandViftyCtlStatusReportencode nil optionals as explicit JSON nulls, matching the status/diagnose schemas' required keys in the idle payload.\n\n## Verification\n-swift buildgreen; ViftyCtlRunnerTests 83/83 with the encode change (from the prior batch run); AppModelPreferencesTests green with the backup change.\n\n## Non-claims\n- No release/tag mutation.