Skip to content

Rename component detection hints - #1482

Merged
Rel1cx merged 5 commits into
mainfrom
component-detection-hint
Feb 7, 2026
Merged

Rename component detection hints#1482
Rel1cx merged 5 commits into
mainfrom
component-detection-hint

Conversation

@Rel1cx

@Rel1cx Rel1cx commented Feb 7, 2026

Copy link
Copy Markdown
Owner

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Perf
  • Docs
  • Test
  • Chore
  • Enhancement
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

Rel1cx
Rename detection hint flags for clarity
f51d445 
- Rename JsxDetectionHint flags from Skip* to DoNotIncludeJsxWith*Value
- Rename Strict* flags to Require* for better semantics
- Rename ComponentDetectionHint Skip* flags to DoNotIncludeFunctionDefined*
- Update all references and documentation
@Rel1cx
Rel1cx requested a review from Copilot February 7, 2026 10:35
@vercel

vercel Bot commented Feb 7, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
eslint-react Ready Ready Preview, Comment Feb 7, 2026 10:56am

@socket-security

socket-security Bot commented Feb 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatedeslint-plugin-jsdoc@​62.5.2 ⏵ 62.5.397 +110010096 +1100

View full report

Copilot AI reviewed Feb 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the naming of JSX/component detection hint flags across @eslint-react/core, updates downstream rule usage in eslint-plugin-react-x, and regenerates/adjusts generated documentation to match the new names and signatures.

Changes:

  • Renamed JsxDetectionHint / ComponentDetectionHint flag names and updated core logic and rule consumers accordingly.
  • Added a TypeScript symbol fully-qualified-name helper and used it in react-x/no-implicit-key to improve React internal key detection.
  • Regenerated/updated various docs (anchors, parameter optionality, tables) and refreshed pnpm-lock.yaml.

Reviewed changes

Copilot reviewed 42 out of 43 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
pnpm-lock.yaml Dependency lock updates.
packages/utilities/eff/docs/functions/flow.md Doc table cleanup (placeholder descriptions).
packages/shared/docs/variables/DEFAULT_ESLINT_SETTINGS.md Updated generated anchor IDs.
packages/shared/docs/variables/DEFAULT_ESLINT_REACT_SETTINGS.md Updated generated anchor IDs.
packages/shared/docs/type-aliases/RuleSuggest.md Updated generated anchor IDs.
packages/shared/docs/type-aliases/RegExpLike.md Updated generated anchor IDs.
packages/shared/docs/interfaces/ESLintReactSettingsNormalized.md Updated generated anchor IDs.
packages/shared/docs/interfaces/CompatibleRule.md Updated generated anchor IDs.
packages/shared/docs/interfaces/CompatiblePlugin.md Updated generated anchor IDs.
packages/shared/docs/interfaces/CompatibleConfig.md Updated generated anchor IDs.
packages/shared/docs/classes/IdGenerator.md Updated constructor signature in docs to match optional prefix defaulting.
packages/plugins/eslint-plugin-react-x/src/utils/type-name.ts New helper getFullyQualifiedNameEx for improved symbol naming.
packages/plugins/eslint-plugin-react-x/src/utils/index.ts Re-exported new type-name utilities.
packages/plugins/eslint-plugin-react-x/src/rules/no-nested-component-definitions.ts Updated detection hint bitflags to renamed constants.
packages/plugins/eslint-plugin-react-x/src/rules/no-implicit-key.ts Switched internal-key detection to use getFullyQualifiedNameEx.
packages/core/src/jsx/jsx-detection.ts Renamed JsxDetectionHint flags and updated isJsxLike logic/defaults.
packages/core/src/component/component-detection-hint.ts Renamed ComponentDetectionHint flags and updated default hint composition.
packages/core/src/component/component-definition.ts Updated hint checks to renamed flags.
packages/core/docs/variables/JsxEmit.md Updated generated anchor IDs.
packages/core/docs/variables/JsxDetectionHint.md Updated docs to renamed hint fields and new anchors.
packages/core/docs/variables/ComponentFlag.md Updated generated anchor IDs.
packages/core/docs/variables/ComponentDetectionHint.md Updated docs to renamed hint fields and new anchors.
packages/core/docs/interfaces/ServerFunctionSemanticNode.md Updated generated anchor IDs and cross-links.
packages/core/docs/interfaces/SemanticNode.md Updated generated anchor IDs.
packages/core/docs/interfaces/SemanticFunc.md Updated generated anchor IDs and cross-links.
packages/core/docs/interfaces/JsxConfig.md Updated generated anchor IDs.
packages/core/docs/interfaces/HookSemanticNode.md Updated generated anchor IDs and cross-links.
packages/core/docs/interfaces/FunctionComponentSemanticNode.md Updated generated anchor IDs and cross-links.
packages/core/docs/interfaces/ClientFunctionSemanticNode.md Updated generated anchor IDs and cross-links.
packages/core/docs/interfaces/ClassComponentSemanticNode.md Updated generated anchor IDs and cross-links.
packages/core/docs/functions/useComponentCollector.md Updated signature in docs to show optional options (defaulted).
packages/core/docs/functions/isUseStateLikeCall.md Updated signature in docs to show optional regex param (defaulted).
packages/core/docs/functions/isUseEffectLikeCall.md Updated signature in docs to show optional regex param (defaulted).
packages/core/docs/functions/isJsxLike.md Updated signature in docs to show optional hint param (defaulted).
packages/core/docs/functions/isInitializedFromReactNative.md Updated signature in docs to show optional importSource param.
packages/core/docs/functions/isInitializedFromReact.md Updated signature in docs to show optional importSource param.
packages/core/docs/functions/isFunctionWithLooseComponentName.md Updated signature in docs to show optional allowNone param.
packages/core/docs/functions/findParentJsxAttribute.md Updated signature in docs to show optional test param (defaulted).
packages/core/docs/functions/findEnclosingComponentOrHook.md Updated signature in docs to show optional filter param (defaulted).
packages/core/docs/@eslint-react/namespaces/useHookCollector/type-aliases/ReturnType.md Updated generated anchor IDs.
packages/core/docs/@eslint-react/namespaces/useComponentCollectorLegacy/type-aliases/ReturnType.md Updated generated anchor IDs.
packages/core/docs/@eslint-react/namespaces/useComponentCollector/type-aliases/ReturnType.md Updated generated anchor IDs.
packages/core/docs/@eslint-react/namespaces/useComponentCollector/type-aliases/Options.md Updated generated anchor IDs.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/core/src/jsx/jsx-detection.ts
Comment thread packages/core/src/component/component-detection-hint.ts Outdated
Comment thread packages/plugins/eslint-plugin-react-x/src/rules/no-nested-component-definitions.ts
Comment thread packages/core/src/component/component-detection-hint.ts
Comment thread packages/core/src/jsx/jsx-detection.ts
Comment thread packages/core/src/jsx/jsx-detection.ts
@Rel1cx
Rel1cx force-pushed the component-detection-hint branch from 049b5c4 to 49d031e Compare February 7, 2026 10:40
Copilot AI mentioned this pull request Feb 7, 2026
Merged
5 tasks

Copilot AI commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

@Rel1cx I've opened a new pull request, #1483, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI mentioned this pull request Feb 7, 2026
Merged
4 tasks

Copilot AI commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

@Rel1cx I've opened a new pull request, #1484, to work on those changes. Once the pull request is ready, I'll request review from you.

[WIP] Update component detection hints based on feedback (#1483)
e2568d9 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@Rel1cx
[WIP] WIP address feedback on renaming component detection hints (#1484)
17af0e8 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: REL1CX <solarflamex@hotmail.com>

Copilot AI commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

@Rel1cx I've opened a new pull request, #1485, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI mentioned this pull request Feb 7, 2026
Merged
@Rel1cx
Rel1cx force-pushed the component-detection-hint branch from c4b45b1 to d9bd7b6 Compare February 7, 2026 10:50
@Rel1cx
[WIP] WIP address feedback on renaming component detection hints (#1485)
579ea7e 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@Rel1cx
Rel1cx force-pushed the component-detection-hint branch from d9bd7b6 to 579ea7e Compare February 7, 2026 10:53
@Rel1cx
Rel1cx merged commit 198f964 into main Feb 7, 2026
10 of 11 checks passed
@Rel1cx
Rel1cx deleted the component-detection-hint branch February 7, 2026 10:54
Rel1cx added a commit that referenced this pull request May 15, 2026
@Rel1cx Rel1cx
Rename component detection hints (#1482)
ba79dba 
Co-authored-by: Rel1cx <solflamex@hotmail.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rel1cx