fix: secrets__enum infinite loop from broken pagination (closes #487)#503
Open
raajheshkannaa wants to merge 1 commit intoRhinoSecurityLabs:masterfrom
Open
fix: secrets__enum infinite loop from broken pagination (closes #487)#503raajheshkannaa wants to merge 1 commit intoRhinoSecurityLabs:masterfrom
raajheshkannaa wants to merge 1 commit intoRhinoSecurityLabs:masterfrom
Conversation
…noSecurityLabs#487) list_secrets() NextToken was never passed to subsequent calls, causing an infinite loop. describe_parameters() had the same issue — only the first page was ever fetched. Fixed both to properly paginate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list_secrets()never passesNextTokento subsequent API calls — the token variable is initialized toFalseand never updated, so the loop re-fetches the first page forever when the response containsNextToken.describe_parameters()had a similar issue — thewhile response is Noneloop only fetches one page, silently dropping all subsequent pages.Fixed both to properly paginate using
response.get('NextToken')and passing it to the next call.Fixes #487