Skip to content

fix: secrets__enum infinite loop from broken pagination (closes #487) #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raajheshkannaa wants to merge 1 commit into
base: master
Choose a base branch
from
+46 −45
Open

fix: secrets__enum infinite loop from broken pagination (closes #487) #503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 46 additions & 45 deletions pacu/modules/secrets__enum/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,42 +63,40 @@ def main(args, pacu_main: 'Main'):
if args.secrets_manager:
client = pacu_main.get_boto3_client('secretsmanager', region)

response = None
next_token = False
while (response is None) or 'NextToken' in response:
if next_token is False:
try:
response = client.list_secrets()
except ClientError as error:
code = error.response['Error']['Code']
print('FAILURE: ')
if code == 'UnauthorizedOperation':
print(' Access denied to ListSecrets.')
else:
print(' ' + code)
print(' Could not list secrets... Exiting')
response = None
break
except EndpointConnectionError as error:
print(
' Error connecting to SecretsManager Endpoint for listing secrets for region: {}'.format(
region))
print(' Error: {}, {}'.format(error.__class__, str(error)))
response = None
break
except Exception as error:
print(' Generic Error when Listing SecretsManager for region: {}'.format(region))
print(' Error: {}, {}'.format(error.__class__, str(error)))
response = None
break

else:
response = client.list_secrets()

if response:
for secret in response['SecretList']:
print(' Found secret: {}'.format(secret["Name"]))
secret_ids.append({"name": secret["Name"], "region": region})
next_token = None
while True:
try:
kwargs = {}
if next_token:
kwargs['NextToken'] = next_token
response = client.list_secrets(**kwargs)
except ClientError as error:
code = error.response['Error']['Code']
print('FAILURE: ')
if code == 'UnauthorizedOperation':
print(' Access denied to ListSecrets.')
else:
print(' ' + code)
print(' Could not list secrets... Exiting')
break
except EndpointConnectionError as error:
print(
' Error connecting to SecretsManager Endpoint for listing secrets for region: {}'.format(
region))
print(' Error: {}, {}'.format(error.__class__, str(error)))
break
except Exception as error:
print(' Generic Error when Listing SecretsManager for region: {}'.format(region))
print(' Error: {}, {}'.format(error.__class__, str(error)))
break

for secret in response['SecretList']:
print(' Found secret: {}'.format(secret["Name"]))
secret_ids.append({"name": secret["Name"], "region": region})

next_token = response.get('NextToken')
if not next_token:
break

all_secrets_ids_sm += secret_ids

Expand Down Expand Up @@ -144,10 +142,13 @@ def main(args, pacu_main: 'Main'):
print("Probing parameter store")
client = pacu_main.get_boto3_client('ssm', region)

response = None
while response is None:
next_token = None
while True:
try:
response = client.describe_parameters()
kwargs = {}
if next_token:
kwargs['NextToken'] = next_token
response = client.describe_parameters(**kwargs)
except ClientError as error:
code = error.response['Error']['Code']
print(' FAILURE: ')
Expand All @@ -156,23 +157,23 @@ def main(args, pacu_main: 'Main'):
else:
print(' ' + code)
print(' Could not list parameters... Exiting')
response = None
break
except EndpointConnectionError as error:
print(' Error connecting to SSM Endpoint for describing SSM Parameters for region: {}'.format(
region))
print(' Error: {}, {}'.format(error.__class__, str(error)))
response = None
break
except Exception as error:
print(' Generic Error when describing SSM Parameters for region: {}'.format(region))
print(' Error: {}, {}'.format(error.__class__, str(error)))
response = None
break

if response:
for param in response["Parameters"]:
secrets_ssm.append({"name": param["Name"], "type": param["Type"], "region": region})
for param in response["Parameters"]:
secrets_ssm.append({"name": param["Name"], "type": param["Type"], "region": region})

next_token = response.get('NextToken')
if not next_token:
break

all_secrets_ids_ssm += secrets_ssm

Expand Down