test: document rule-extraction case, punctuation and Unicode behavior (#2) - #4
Open
Cid-oe wants to merge 1 commit into
Open
test: document rule-extraction case, punctuation and Unicode behavior (#2)#4Cid-oe wants to merge 1 commit into
Cid-oe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2.
Documents and asserts
RuleExtractor's regression behavior across whitespace trimming, sentence-final punctuation, repeated punctuation, English case normalization, non-ASCII/Unicode letters, mixed CJK/Latin phrasing, and unsupported edge cases.Changes
src/extract.rs):rule_extractor_behavior_matrixasserting positive extractions for:.,!,?).!!!???).喝).ALICE PREFERS VIM->alice,prefers,vim).Bob Works At Microsoft.).Jürgen likes München) and accented characters (Renée lives in Paris).Bob 住在 上海).Rust is liked by Alice).Alice likes Alice).docs/guide.md):README.zh-CN.md):docs/guide.md#rule-extraction-behavior-matrix.Validation
cargo testpasses (61/61 library tests, all CLI & integration tests green).cargo clippy --all-targets --all-features -- -D warningspasses with zero warnings.git diff --checkpasses cleanly.