-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor the robotic manipulation package #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kacper Dąbrowski <[email protected]>
Signed-off-by: Kacper Dąbrowski <[email protected]>
Signed-off-by: Kacper Dąbrowski <[email protected]>
Signed-off-by: Kacper Dąbrowski <[email protected]>
Signed-off-by: Kacper Dąbrowski <[email protected]>
Signed-off-by: Kacper Dąbrowski <[email protected]>
Signed-off-by: Kacper Dąbrowski <[email protected]>
bba007b
to
206c68c
Compare
Rebased and force-pushed your branch after integrating other changes to the repository. |
ros2_ws/src/robotic_manipulation/include/robotic_manipulation/rai_manipulation_interface_node.h
Show resolved
Hide resolved
ros2_ws/src/robotic_manipulation/include/robotic_manipulation/rai_manipulation_interface_node.h
Show resolved
Hide resolved
Signed-off-by: Kacper Dąbrowski <[email protected]>
5877993
to
b9152fa
Compare
Signed-off-by: Kacper Dąbrowski <[email protected]>
Signed-off-by: Kacper Dąbrowski <[email protected]>
Signed-off-by: Kacper Dąbrowski <[email protected]>
1389dec
to
131bb20
Compare
@knicked What is the status of this PR? |
Waiting for approve from @jhanca-robotecai. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds and works as expected.
My only concern is using different .clang-format
configurations within one company. I guess the only reasoning is to highlight the difference between the AI Team and the rest ;)
This PR refactors the robotic manipulation package to improve the quality of the code. In particular, this PR:
StateController
class to better mirror its purposepackage.xml