Skip to content

Refactor the robotic manipulation package #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 28, 2025
Merged

Conversation

knicked
Copy link
Contributor

@knicked knicked commented Mar 24, 2025

This PR refactors the robotic manipulation package to improve the quality of the code. In particular, this PR:

  • Decouples service initialization code with node spinning code
  • Renames the StateController class to better mirror its purpose
  • Replaces magic values with constants
  • Formats all the files using clang-format
  • Adds a license note to every source code file
  • Fills the package description and license information in package.xml

@jhanca-robotecai jhanca-robotecai self-requested a review March 25, 2025 15:49
@jhanca-robotecai jhanca-robotecai removed their assignment Mar 25, 2025
Base automatically changed from kd/wait_for_clock to development March 28, 2025 12:02
@jhanca-robotecai
Copy link
Collaborator

Rebased and force-pushed your branch after integrating other changes to the repository.

Signed-off-by: Kacper Dąbrowski <[email protected]>
knicked added 3 commits March 31, 2025 15:11
Signed-off-by: Kacper Dąbrowski <[email protected]>
Signed-off-by: Kacper Dąbrowski <[email protected]>
Signed-off-by: Kacper Dąbrowski <[email protected]>
@boczekbartek
Copy link
Member

@knicked What is the status of this PR?

@knicked
Copy link
Contributor Author

knicked commented May 21, 2025

Waiting for approve from @jhanca-robotecai.

Copy link
Collaborator

@jhanca-robotecai jhanca-robotecai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works as expected.
My only concern is using different .clang-format configurations within one company. I guess the only reasoning is to highlight the difference between the AI Team and the rest ;)

@knicked knicked merged commit 8bfd695 into development May 28, 2025
@jhanca-robotecai jhanca-robotecai deleted the kd/code_refactor branch June 2, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants