Skip to content

replace unpkg with jsdeliver in quick start instructions #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025

Conversation

brothhammer
Copy link
Collaborator

Brief Description

The unpkg tool is no longer working as expected so we are replacing it with jsdelivr

JIRA Link

https://rocketcom.atlassian.net/browse/AP-400?linkSource=email

Related Issue

General Notes

I created an "astro-playground" on my personal git hub. For some reason I could not push to a new repository created under the Rocket account.

https://github.com/brothhammer/astro-playground

If you pull that repo you can run with the "Liver Server" plugin for VS code by right clicking in the file and selecting run with Live Server.
image

After we merge this we need to properly deploy StoryBook. The instructions for that can be found in Confluence here
https://rocketcom.atlassian.net/wiki/spaces/AS11/pages/3740565534/Astro+Deployment+Instructions

Motivation and Context

We do not want customers getting frustrated trying to follow the Quick Start instructions.

Issues and Limitations

Types of changes

  • Non working instructions for quick start

Checklist

  • This PR adds or removes a Storybook story.
  • I have added tests to cover my changes.
  • Regressions are passing and/or failures are documented
  • Changes have been checked in evergreen browsers

Copy link

changeset-bot bot commented Apr 3, 2025

⚠️ No Changeset found

Latest commit: dbca37f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for astro-preview ready!

Name Link
🔨 Latest commit dbca37f
🔍 Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/67eef046b4fb260008c7518e
😎 Deploy Preview https://deploy-preview-1378--astro-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for astro-stencil ready!

Name Link
🔨 Latest commit dbca37f
🔍 Latest deploy log https://app.netlify.com/sites/astro-stencil/deploys/67eef046b4fb260008c7518a
😎 Deploy Preview https://deploy-preview-1378--astro-stencil.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brothhammer brothhammer marked this pull request as ready for review April 3, 2025 17:42
@brothhammer brothhammer requested a review from FMorrison87 April 3, 2025 17:42
Copy link
Contributor

@FMorrison87 FMorrison87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to change the web components README as well, as that references unpkg: https://github.com/RocketCommunicationsInc/astro/blob/main/packages/web-components/README.md

Copy link
Contributor

@FMorrison87 FMorrison87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙌

@brothhammer brothhammer merged commit 2c89c3c into main Apr 3, 2025
7 checks passed
@brothhammer brothhammer deleted the swap-unpk-for-Jsdlivr---Quick-Start-only branch April 3, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants