-
Notifications
You must be signed in to change notification settings - Fork 28
replace unpkg with jsdeliver in quick start instructions #1378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Deploy Preview for astro-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for astro-stencil ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to change the web components README as well, as that references unpkg: https://github.com/RocketCommunicationsInc/astro/blob/main/packages/web-components/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🙌
Brief Description
The
unpkg
tool is no longer working as expected so we are replacing it withjsdelivr
JIRA Link
https://rocketcom.atlassian.net/browse/AP-400?linkSource=email
Related Issue
General Notes
I created an "astro-playground" on my personal git hub. For some reason I could not push to a new repository created under the Rocket account.
https://github.com/brothhammer/astro-playground
If you pull that repo you can run with the "Liver Server" plugin for VS code by right clicking in the file and selecting run with Live Server.

After we merge this we need to properly deploy StoryBook. The instructions for that can be found in Confluence here
https://rocketcom.atlassian.net/wiki/spaces/AS11/pages/3740565534/Astro+Deployment+Instructions
Motivation and Context
We do not want customers getting frustrated trying to follow the Quick Start instructions.
Issues and Limitations
Types of changes
Checklist