Add Campari paths to snpit_system_config.yaml #9
Conversation
Added Campari configuration paths for simulations and output.
rknop
left a comment
rknop
left a comment
There was a problem hiding this comment.
You might want to look at all the command-line options you have for campari right now. Some of them might reasonably be turned into configuration options. They can still be overridden on the command line.
The key is that anything that affects campari's behavior, other than specific things like the band, the list of input files, the object id, all need to be part of the parameters in the provenance. If you have things that affect how campari runs that you pass on the command line but that aren't in the config, then the way you are building provenances as of the current state of the campari Provenance PR, you're going to be missing all that.
| sims_sed_library: /home/rubin_sim_data/sims_sed_library | ||
| campari_test_data: /campari_test_data | ||
| sed_path: /campari_sed_dir | ||
| output_dir: /campari_out_dir |
There was a problem hiding this comment.
Maybe system.paths.campari.paths.output_dir is still useful, but :
When writing lightcurves to the databse, you're going to need to use system.paths.lightcurves as the base path. You will want to let snappl choose the rest of the path. (This was in a comment on your Provenance campari PR.)
It's fine to leave this here for now, but we'll want to revisit all of these and prune out the things not used any more.
| A25ePSF_path: /home/snappl/snappl/tests/testdata/A25ePSF | ||
|
|
||
| campari: | ||
| paths: |
There was a problem hiding this comment.
...isn't this a bit much? system.paths.campari.etc should be fine, whereas system.paths.campari.paths.etc has paths in it twice.
The system.paths.campari config variables should be for temp storage and storage of campari stuff that we're not persisting in the database. Currently, we're only persisting the lightcurve; those will go underneath system.paths.lightcurves. We may later decide to persist other stuff.
Added Campari configuration paths for simulations and output.