Skip to content

Add Campari paths to snpit_system_config.yaml #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ColeFMeldorf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Campari paths to snpit_system_config.yaml #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions snpit_system_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,18 @@ system:
# Paths used by snappl library modules
snappl:
A25ePSF_path: /home/snappl/snappl/tests/testdata/A25ePSF

campari:
paths:
Copy link
Contributor

@rknop rknop Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...isn't this a bit much? system.paths.campari.etc should be fine, whereas system.paths.campari.paths.etc has paths in it twice.

The system.paths.campari config variables should be for temp storage and storage of campari stuff that we're not persisting in the database. Currently, we're only persisting the lightcurve; those will go underneath system.paths.lightcurves. We may later decide to persist other stuff.

sims_sed_library: /home/rubin_sim_data/sims_sed_library
campari_test_data: /campari_test_data
sed_path: /campari_sed_dir
output_dir: /campari_out_dir
Copy link
Contributor

@rknop rknop Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe system.paths.campari.paths.output_dir is still useful, but :

When writing lightcurves to the databse, you're going to need to use system.paths.lightcurves as the base path. You will want to let snappl choose the rest of the path. (This was in a comment on your Provenance campari PR.)

It's fine to leave this here for now, but we'll want to revisit all of these and prune out the things not used any more.

debug_dir: /campari_debug_dir

# OMG
galsim:
tds_file: /campari/examples/perlmutter/tds.yaml

# Paths used by phrosty
phrosty:
Expand Down